* [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path
@ 2026-08-06 3:29 Hangbin Liu
2026-08-06 11:23 ` Fernando Fernandez Mancera
2026-08-10 23:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2026-08-06 3:29 UTC (permalink / raw)
To: Jay Vosburgh, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Jonathan Toppins
Cc: Jay Vosburgh, netdev, linux-kernel, Hangbin Liu, Hangbin Liu
From: Hangbin Liu <liuhangbin@kylinos.cn>
The attribute of netlink error message should be IFLA_BOND_ARP_VALIDATE
when ARP validation setting fails.
Fixes: 2bff369b2354 ("bonding: netlink error message support for options")
Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
---
drivers/net/bonding/bond_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
index 4a11572f663d..7dc31b2551c4 100644
--- a/drivers/net/bonding/bond_netlink.c
+++ b/drivers/net/bonding/bond_netlink.c
@@ -372,7 +372,7 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
int arp_validate = nla_get_u32(data[IFLA_BOND_ARP_VALIDATE]);
if (arp_validate && miimon) {
- NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_INTERVAL],
+ NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_VALIDATE],
"ARP validating cannot be used with MII monitoring");
return -EINVAL;
}
---
base-commit: 2a33516f9ef59ad11844d4fc152f889449b5daf3
change-id: 20260806-bond_arp_validate-359289656609
Best regards,
--
Hangbin Liu <liuhangbin@kylinos.cn>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path
2026-08-06 3:29 [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path Hangbin Liu
@ 2026-08-06 11:23 ` Fernando Fernandez Mancera
2026-08-10 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Fernando Fernandez Mancera @ 2026-08-06 11:23 UTC (permalink / raw)
To: Hangbin Liu, Jay Vosburgh, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jonathan Toppins
Cc: Jay Vosburgh, netdev, linux-kernel, Hangbin Liu
On 8/6/26 5:29 AM, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
>
> The attribute of netlink error message should be IFLA_BOND_ARP_VALIDATE
> when ARP validation setting fails.
>
> Fixes: 2bff369b2354 ("bonding: netlink error message support for options")
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
> ---
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Thanks!
> drivers/net/bonding/bond_netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> index 4a11572f663d..7dc31b2551c4 100644
> --- a/drivers/net/bonding/bond_netlink.c
> +++ b/drivers/net/bonding/bond_netlink.c
> @@ -372,7 +372,7 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
> int arp_validate = nla_get_u32(data[IFLA_BOND_ARP_VALIDATE]);
>
> if (arp_validate && miimon) {
> - NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_INTERVAL],
> + NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_VALIDATE],
> "ARP validating cannot be used with MII monitoring");
> return -EINVAL;
> }
>
> ---
> base-commit: 2a33516f9ef59ad11844d4fc152f889449b5daf3
> change-id: 20260806-bond_arp_validate-359289656609
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path
2026-08-06 3:29 [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path Hangbin Liu
2026-08-06 11:23 ` Fernando Fernandez Mancera
@ 2026-08-10 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-08-10 23:20 UTC (permalink / raw)
To: Hangbin Liu
Cc: jv, andrew+netdev, davem, edumazet, kuba, pabeni,
jon.toppins+linux, jay.vosburgh, netdev, linux-kernel, liuhangbin
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 06 Aug 2026 11:29:28 +0800 you wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
>
> The attribute of netlink error message should be IFLA_BOND_ARP_VALIDATE
> when ARP validation setting fails.
>
> Fixes: 2bff369b2354 ("bonding: netlink error message support for options")
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
>
> [...]
Here is the summary with links:
- [net] bonding: fix wrong extack attribute in ARP validate netlink error path
https://git.kernel.org/netdev/net-next/c/fd23a7c97317
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-10 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 3:29 [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path Hangbin Liu
2026-08-06 11:23 ` Fernando Fernandez Mancera
2026-08-10 23:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.