From: patchwork-bot+netdevbpf@kernel.org
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net 01/13] netfilter: ipset: fix refcount race between list:set GC and swap
Date: Wed, 12 Aug 2026 01:40:23 +0000 [thread overview]
Message-ID: <178649882389.1230679.84745710900451719.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260810190621.894119-2-pablo@netfilter.org>
Hello:
This series was applied to netdev/net.git (main)
by Pablo Neira Ayuso <pablo@netfilter.org>:
On Mon, 10 Aug 2026 21:06:09 +0200 you wrote:
> From: "Xiang Mei (Microsoft)" <xmei5@asu.edu>
>
> __ip_set_put_byindex() resolved the index to a set pointer under RCU,
> then took ip_set_ref_lock in __ip_set_put() to decrement set->ref.
> ip_set_swap() holds that same lock while swapping both the ip_set_list
> slots and the two sets' ref counters, so it can interleave between the
> dereference and the lock acquisition, leaving the caller to decrement a
> set whose reference already moved to the other index and hit
> BUG_ON(set->ref == 0). list_set_gc() reaches this from timer softirq,
> which the nfnl mutex does not serialize against swap: an expiring
> list:set member calls list_set_del() -> ip_set_put_byindex() while
> IPSET_CMD_SWAP runs on the referenced sets.
>
> [...]
Here is the summary with links:
- [net,01/13] netfilter: ipset: fix refcount race between list:set GC and swap
https://git.kernel.org/netdev/net/c/0c8886827165
- [net,02/13] netfilter: bridge: release template ct on non-IP path
https://git.kernel.org/netdev/net/c/d45cc8020d7c
- [net,03/13] ipvs: add totalconns for dest
https://git.kernel.org/netdev/net/c/04d2feaed8d0
- [net,04/13] ipvs: properly update the overload flag on dest edit
https://git.kernel.org/netdev/net/c/8f843441c4e7
- [net,05/13] ipvs: separate destination availability state
https://git.kernel.org/netdev/net/c/cdcc4e46180d
- [net,06/13] netfilter: nf_conntrack: defer invalid log until after unlock
https://git.kernel.org/netdev/net/c/2d19b95c9723
- [net,07/13] netfilter: nfnetlink_log: wait for rcu grace period before freeing pernet state
https://git.kernel.org/netdev/net/c/33d1469b0124
- [net,08/13] ipvs: clear IPv4 options after rebasing tunnel ICMP errors
https://git.kernel.org/netdev/net/c/e0ba936287df
- [net,09/13] ipvs: revalidate ihl to prevent out-of-bounds access
https://git.kernel.org/netdev/net/c/d93660df4dd1
- [net,10/13] netfilter: nf_tables_offload: suppress WARN_ON_ONCE for ENOMEM in abort path
https://git.kernel.org/netdev/net/c/d02f59206434
- [net,11/13] netfilter: flowtable: publish GC-visible tuple last
https://git.kernel.org/netdev/net/c/2014ac62df9d
- [net,12/13] netfilter: ipset: fix list type element drift bug
https://git.kernel.org/netdev/net/c/4cbd69766b35
- [net,13/13] netfilter: ipset: let destroy callbacks adjust ext mem size
https://git.kernel.org/netdev/net/c/490937b88cb5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2026-08-12 1:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 19:06 [PATCH net 00/13] Netfilter/IPVS fixes for net Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 01/13] netfilter: ipset: fix refcount race between list:set GC and swap Pablo Neira Ayuso
2026-08-12 1:40 ` patchwork-bot+netdevbpf [this message]
2026-08-10 19:06 ` [PATCH net 02/13] netfilter: bridge: release template ct on non-IP path Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 03/13] ipvs: add totalconns for dest Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 04/13] ipvs: properly update the overload flag on dest edit Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 05/13] ipvs: separate destination availability state Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 06/13] netfilter: nf_conntrack: defer invalid log until after unlock Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 07/13] netfilter: nfnetlink_log: wait for rcu grace period before freeing pernet state Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 08/13] ipvs: clear IPv4 options after rebasing tunnel ICMP errors Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 09/13] ipvs: revalidate ihl to prevent out-of-bounds access Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 10/13] netfilter: nf_tables_offload: suppress WARN_ON_ONCE for ENOMEM in abort path Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 11/13] netfilter: flowtable: publish GC-visible tuple last Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 12/13] netfilter: ipset: fix list type element drift bug Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 13/13] netfilter: ipset: let destroy callbacks adjust ext mem size Pablo Neira Ayuso
2026-08-11 19:44 ` [PATCH net 00/13] Netfilter/IPVS fixes for net Jakub Kicinski
2026-08-11 20:23 ` Florian Westphal
2026-08-11 22:22 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178649882389.1230679.84745710900451719.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.