From: Florian Westphal <fw@strlen.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, ja@ssi.bg
Subject: Re: [PATCH net 00/13] Netfilter/IPVS fixes for net
Date: Tue, 11 Aug 2026 22:23:33 +0200 [thread overview]
Message-ID: <anuEqSHXJtF9bqTi@strlen.de> (raw)
In-Reply-To: <20260811124434.76ab55d9@kernel.org>
Jakub Kicinski <kuba@kernel.org> wrote:
> On Mon, 10 Aug 2026 21:06:08 +0200 Pablo Neira Ayuso wrote:
> > The following patchset contains Netfilter/IPVS fixes for net. Still
> > large batch for this late -rc cycle but at least have of these fixes in
> > this batch have been cooking for several weeks before:
>
> Does any of the AI-detected issues seem concerning?
>
> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260810190621.894119-4-pablo@netfilter.org
Only commenting on those patches that I worked on or commented during
review:
Patch 6: [PATCH net 06/13] netfilter: nf_conntrack: defer invalid log until after unlock
Its fine. This is for debugging. We could restore the removed info if
anyone needs it, I even was about to suggest to original author to
simply remove the invalid logging but decided against it (since you can
log the packet to userspace via nfnetlink). I prefer the simpler
version that doesn't snapshot data while under lock.
Patch 7: [PATCH net 07/13] netfilter: nfnetlink_log: wait for rcu grace period before freeing pernet state
Yes, one could have added this Fixes tag or Cc stable to the patch.
Don't think this warrants a respin by itself.
Patch 12: [PATCH net 12/13] netfilter: ipset: fix list type element drift bug
Even if the ordering is "wrong", the patch that
added it is ancient (even in RHEL7) so its long established behaviour.
ipset test suite also has test for this and those tests pass, so
changing kernel behaviour will need to adjust (old..) test cases as
well.
next prev parent reply other threads:[~2026-08-11 20:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 19:06 [PATCH net 00/13] Netfilter/IPVS fixes for net Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 01/13] netfilter: ipset: fix refcount race between list:set GC and swap Pablo Neira Ayuso
2026-08-12 1:40 ` patchwork-bot+netdevbpf
2026-08-10 19:06 ` [PATCH net 02/13] netfilter: bridge: release template ct on non-IP path Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 03/13] ipvs: add totalconns for dest Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 04/13] ipvs: properly update the overload flag on dest edit Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 05/13] ipvs: separate destination availability state Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 06/13] netfilter: nf_conntrack: defer invalid log until after unlock Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 07/13] netfilter: nfnetlink_log: wait for rcu grace period before freeing pernet state Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 08/13] ipvs: clear IPv4 options after rebasing tunnel ICMP errors Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 09/13] ipvs: revalidate ihl to prevent out-of-bounds access Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 10/13] netfilter: nf_tables_offload: suppress WARN_ON_ONCE for ENOMEM in abort path Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 11/13] netfilter: flowtable: publish GC-visible tuple last Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 12/13] netfilter: ipset: fix list type element drift bug Pablo Neira Ayuso
2026-08-10 19:06 ` [PATCH net 13/13] netfilter: ipset: let destroy callbacks adjust ext mem size Pablo Neira Ayuso
2026-08-11 19:44 ` [PATCH net 00/13] Netfilter/IPVS fixes for net Jakub Kicinski
2026-08-11 20:23 ` Florian Westphal [this message]
2026-08-11 22:22 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2026-07-22 21:14 Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anuEqSHXJtF9bqTi@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.