Re: [PATCH] staging: rtl8188eu: Replace a custom function with crc32_le()

["Fabio M. De Francesco" <fmdefrancesco@gmail.com>]

On Saturday, July 10, 2021 2:25:12 AM CEST kernel test robot wrote:
> Hi "Fabio,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on staging/staging-testing]
> 
> url:   
> https://github.com/0day-ci/linux/commits/Fabio-M-De-Francesco/staging-rtl8188eu-Replace
> -a-custom-function-with-crc32_le/20210701-213922 base:  
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> 77ad1f0e99bd00af024e650b862cfda3137af660 config: powerpc64-randconfig-
s032-20210709

[CUT]

> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/staging/rtl8188eu/core/rtw_security.c:597:58: sparse: sparse: 
incorrect type
> >> in assignment (different base types) @@     expected restricted __le32 
[usertype] @@
> >>     got unsigned int @@
>    drivers/staging/rtl8188eu/core/rtw_security.c:597:58: sparse:     
expected restricted
> __le32 [usertype] drivers/staging/rtl8188eu/core/rtw_security.c:597:58: 
sparse:     got
> unsigned int drivers/staging/rtl8188eu/core/rtw_security.c:604:58: sparse: 
sparse:
> incorrect type in assignment (different base types) @@     expected 
restricted __le32
> [usertype] @@     got unsigned int @@
> drivers/staging/rtl8188eu/core/rtw_security.c:604:58: sparse:     expected 
restricted
> __le32 [usertype] drivers/staging/rtl8188eu/core/rtw_security.c:604:58: 
sparse:     got
> unsigned int drivers/staging/rtl8188eu/core/rtw_security.c:671:42: sparse: 
sparse:
> incorrect type in assignment (different base types) @@     expected 
restricted __le32
> [usertype] @@     got unsigned int @@
> drivers/staging/rtl8188eu/core/rtw_security.c:671:42: sparse:     expected 
restricted
> __le32 [usertype] drivers/staging/rtl8188eu/core/rtw_security.c:671:42: 
sparse:     got
> unsigned int

[CUT]

I suppose that these warnings are false positives for the reasons explained in 
my patch.

Furthermore, I found a commit by Fabio Aiuto <fabioaiuto83@gmail.com> that, as 
far as I understand, do the same changes and that has been accepted by Greg K-
H and merged in his tree: b97fad10de387c09ae46f607955c7237afa96654. So, I 
think there one reason more to suspect of false positives.

I'd appreciate comments on this topic.

Thanks,

Fabio