All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mctp: accept MSG_CMSG_COMPAT in recvmsg
@ 2026-11-01 20:03 Davidlohr Bueso
  2026-11-01 20:09 ` netdev-bot+sinfo
  0 siblings, 1 reply; 3+ messages in thread
From: Davidlohr Bueso @ 2026-11-01 20:03 UTC (permalink / raw)
  To: jk, matt, kuba, pabeni; +Cc: anisa.su, dave, netdev, linux-kernel

32-bit userspace running on a 64-bit kernel is unable to receive MCTP
messages on an AF_MCTP socket, even though sending succeeds. There is
nothing for MCTP to do with it beyond not rejecting it, as af_packet,
af_key and can/isotp already do, for example.

Fixes: 833ef3b91de6 ("mctp: Populate socket implementation")
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
 net/mctp/af_mctp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mctp/af_mctp.c b/net/mctp/af_mctp.c
index 8af5e2b3c8d1..aa22c0860712 100644
--- a/net/mctp/af_mctp.c
+++ b/net/mctp/af_mctp.c
@@ -292,8 +292,7 @@ static int mctp_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 	u8 type;
 	int rc;
 
-	if (flags & ~(MSG_DONTWAIT | MSG_TRUNC | MSG_PEEK))
+	if (flags & ~(MSG_DONTWAIT | MSG_TRUNC | MSG_PEEK | MSG_CMSG_COMPAT))
 		return -EOPNOTSUPP;
 
 	skb = skb_recv_datagram(sk, flags, &rc);
--
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mctp: accept MSG_CMSG_COMPAT in recvmsg
  2026-11-01 20:03 [PATCH] mctp: accept MSG_CMSG_COMPAT in recvmsg Davidlohr Bueso
@ 2026-11-01 20:09 ` netdev-bot+sinfo
  2026-11-01 20:41   ` Davidlohr Bueso
  0 siblings, 1 reply; 3+ messages in thread
From: netdev-bot+sinfo @ 2026-11-01 20:09 UTC (permalink / raw)
  To: Davidlohr Bueso; +Cc: jk, matt, kuba, pabeni, anisa.su, netdev, linux-kernel

Hi!

This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:

 - How the issue was discovered, e.g. hit in production, hit during
   development, syzbot report, manual code inspection, LLM or static
   analysis tool scan.

Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.

The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mctp: accept MSG_CMSG_COMPAT in recvmsg
  2026-11-01 20:09 ` netdev-bot+sinfo
@ 2026-11-01 20:41   ` Davidlohr Bueso
  0 siblings, 0 replies; 3+ messages in thread
From: Davidlohr Bueso @ 2026-11-01 20:41 UTC (permalink / raw)
  To: netdev-bot+sinfo; +Cc: jk, matt, kuba, pabeni, anisa.su, netdev, linux-kernel

On Sun, 01 Nov 2026, netdev-bot+sinfo@kernel.org wrote:

>Hi!
>
>This is an automated message. This series looks like a fix, but its
>commit messages seem to be missing some information:
>
> - How the issue was discovered, e.g. hit in production, hit during
>   development, syzbot report, manual code inspection, LLM or static
>   analysis tool scan.
>
>Please do not repost the series just to address the above. Instead,
>reply to this email with the missing information, so that reviewers
>can take it into account. If the series needs another revision for
>other reasons, please include the information in the commit messages
>then.

This is not a random fix, I actually ran into this while testing 32-bit
support for libcxlmi: https://github.com/computexpresslink/libcxlmi/pull/62

>
>The evaluation is done by an LLM so it may be wrong, if you think
>that is the case please reply and explain.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-01 20:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-01 20:03 [PATCH] mctp: accept MSG_CMSG_COMPAT in recvmsg Davidlohr Bueso
2026-11-01 20:09 ` netdev-bot+sinfo
2026-11-01 20:41   ` Davidlohr Bueso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.