From: Igor Korotin <igor.korotin@linux.dev>
To: Priya Bala Govindasamy <pgovind2@uci.edu>,
Danilo Krummrich <dakr@kernel.org>,
Daniel Almeida <daniel.almeida@collabora.com>,
Miguel Ojeda <ojeda@kernel.org>
Cc: "Nicolás Antinori" <nico.antinori.7@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
rust-for-linux@vger.kernel.org,
"Ardalan Amiri Sani" <ardalan@uci.edu>,
"Zhiyun Qian" <zhiyunq@cs.ucr.edu>,
"Dylan Zueck" <dzueck@uci.edu>
Subject: Re: [PATCH 1/1] rust: i2c: fix adapter refcounting during unregistration
Date: Wed, 11 Nov 2026 15:06:48 +0000 [thread overview]
Message-ID: <179440960895.2149.15642463251380257016@linux.dev> (raw)
In-Reply-To: <8ee79da8af6557be8ea9cc2ecc74bdb6e4013513.1793488795.git.pgovind2@uci.edu>
Hi Priya, Nicolás,
Priya, nice catch, and a solid PoC.
Nicolás -- this steps on your inc_ref patch from September (still
waiting on Andi). Same function, same root problem really.
I prefer Priya's version. No new C export, no Ack needed from anyone,
just __module_get()/get_device() directly on the pointer we already
know is valid -- and it kills your locking concern too as a side
effect.
Didn't want this to land without you seeing it first. Shout if you
disagree.
Priya -- Reviewed-by: Igor Korotin <igor.korotin@linux.dev>
Cheers
Igor
next prev parent reply other threads:[~2026-11-11 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 0:16 [PATCH 0/1] rust: i2c: fix adapter refcounting during unregistration Priya Bala Govindasamy
2026-11-04 0:19 ` [PATCH 1/1] " Priya Bala Govindasamy
2026-11-11 15:06 ` Igor Korotin [this message]
2026-11-11 18:02 ` Nicolás Antinori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179440960895.2149.15642463251380257016@linux.dev \
--to=igor.korotin@linux.dev \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=andi.shyti@kernel.org \
--cc=ardalan@uci.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dzueck@uci.edu \
--cc=gary@garyguo.net \
--cc=lossin@kernel.org \
--cc=nico.antinori.7@gmail.com \
--cc=ojeda@kernel.org \
--cc=pgovind2@uci.edu \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhiyunq@cs.ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.