From: "Nicolás Antinori" <nico.antinori.7@gmail.com>
To: "Igor Korotin" <igor.korotin@linux.dev>,
"Priya Bala Govindasamy" <pgovind2@uci.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>
Cc: "Andi Shyti" <andi.shyti@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
rust-for-linux@vger.kernel.org,
"Ardalan Amiri Sani" <ardalan@uci.edu>,
"Zhiyun Qian" <zhiyunq@cs.ucr.edu>,
"Dylan Zueck" <dzueck@uci.edu>
Subject: Re: [PATCH 1/1] rust: i2c: fix adapter refcounting during unregistration
Date: Wed, 11 Nov 2026 15:02:22 -0300 [thread overview]
Message-ID: <DMSKUP6NN0CR.1ZO7OE4LUUFYN@gmail.com> (raw)
In-Reply-To: <179440960895.2149.15642463251380257016@linux.dev>
Hello!
On Wed Nov 11, 2026 at 12:06 PM -03, Igor Korotin wrote:
> Hi Priya, Nicolás,
>
> Priya, nice catch, and a solid PoC.
>
> Nicolás -- this steps on your inc_ref patch from September (still
> waiting on Andi). Same function, same root problem really.
>
> I prefer Priya's version. No new C export, no Ack needed from anyone,
> just __module_get()/get_device() directly on the pointer we already
> know is valid -- and it kills your locking concern too as a side
> effect.
>
> Didn't want this to land without you seeing it first. Shout if you
> disagree.
Yes, I think this version is better too. In fact the solution is the
same as the v1 I sent a while back [1] (but Sashiko caught the
CONFIG_MODULE_UNLOAD config problem). My idea was to send that version
fixed (would ended up the same as Priya's patch) but there was a
discussion about adding the C API [2].
Go with this patch, no problem on that!
Best Regards,
Nicolás
[1] https://lore.kernel.org/all/20260615201141.8920-1-nico.antinori.7@gmail.com/T/#u
[2] https://lore.kernel.org/all/DJBDWVUWH3OT.1GDEIJT0R4UTK@garyguo.net/
prev parent reply other threads:[~2026-11-11 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 0:16 [PATCH 0/1] rust: i2c: fix adapter refcounting during unregistration Priya Bala Govindasamy
2026-11-04 0:19 ` [PATCH 1/1] " Priya Bala Govindasamy
2026-11-11 15:06 ` Igor Korotin
2026-11-11 18:02 ` Nicolás Antinori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMSKUP6NN0CR.1ZO7OE4LUUFYN@gmail.com \
--to=nico.antinori.7@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=andi.shyti@kernel.org \
--cc=ardalan@uci.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dzueck@uci.edu \
--cc=gary@garyguo.net \
--cc=igor.korotin@linux.dev \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=pgovind2@uci.edu \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhiyunq@cs.ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.