All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: geliang@kernel.org
Cc: mptcp@lists.linux.dev, kuba@kernel.org
Subject: Re: [PATCH mptcp-next v29 4/8] mptcp: drop the cant_coalesce CB field
Date: Fri, 20 Nov 2026 18:41:50 +0000	[thread overview]
Message-ID: <179520011006.3133.16319687060684256580@kernel.org> (raw)
In-Reply-To: <d93502137d925de91e85c9b4c41ef492f70aa7e9.1795063943.git.tanggeliang@kylinos.cn>

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message for "mptcp: drop the cant_coalesce CB field"
  has three problems.

--

mptcp: drop the cant_coalesce CB field

This patch removes the cant_coalesce field from struct mptcp_skb_cb. The
passive TFO skb is no longer blocked from coalescing. Instead, its map_seq
and end_seq are rewritten from the IASN (stored in msk->tfo_iasn) before
any further skb lands in the msk. When the msk is owned by user space, the
update is deferred through the new MPTCP_SYNC_SEQ cb_flags bit.

> mptcp: drop the cant_coalesce CB field
>
> Such field is used to ensure in-sequence processing in case of fastopen.
> Instead let's perform synchronization of the fastopen skb sequence
> when the IASN becomes available with the 3rd ack.

[Severity: Low]
Does this describe the removed field accurately?

Before this patch, the only reader of cant_coalesce is
__mptcp_try_coalesce() in net/mptcp/protocol.c. There it stops new data
from being merged into the passive TFO skb, which carries the dummy mapping
(map_seq = -len, end_seq = 0).

The field plays no part in the in-sequence, out-of-order or old-data
decision in __mptcp_move_skb(). That decision compares the incoming skb's
mapping against msk->ack_seq.

Commit f03afb3aeb9d ("mptcp: drop __mptcp_fastopen_gen_msk_ackseq()"),
which added the field, says it prevents "collapsing to the first skb of a
fastopen connect". Would similar wording be clearer here?

The message also doesn't give a reason for the change. struct
mptcp_skb_cb uses well under the 48 bytes of skb->cb, so space doesn't
explain it. To replace the one-byte field, the patch adds:

  tfo_iasn and rcvd_dummy_seq in struct mptcp_sock
  the MPTCP_SYNC_SEQ cb_flags bit
  a per-skb branch in __mptcp_move_skb()
  new checks in mptcp_move_skbs() and mptcp_release_cb()

If this prepares for the later "mptcp: remove CB offset field" and "mptcp:
sync mptcp skb cb layout with tcp one" patches in the series, could the
message say so?

Finally, there is a change in behaviour that the message doesn't
describe. After __mptcp_sync_rcv_sequence() sets the TFO skb's end_seq to
tfo_iasn, the next in-sequence skb (map_seq == ack_seq == iasn) passes
this check in __mptcp_try_coalesce():

	if (MPTCP_SKB_CB(from)->map_seq != MPTCP_SKB_CB(to)->end_seq ||
	    MPTCP_SKB_CB(from)->offset ||
	    ...

skb_try_coalesce() can then merge it into the TFO skb, which cant_coalesce
used to prevent.

The new behaviour looks correct, because tfo_iasn - len + offset keeps
map_seq - offset consistent across partial reads. Could the commit message
mention this coalescing change?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1795063943.git.tanggeliang%40kylinos.cn

  reply	other threads:[~2026-11-20 18:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  5:10 [PATCH mptcp-next v29 0/8] Reduce the differences between TCP and MPTCP for TLS usage Geliang Tang
2026-11-19  5:10 ` [PATCH mptcp-net v29 1/8] mptcp: clear rcv_data_fin_seq in mptcp_disconnect Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-net v29 2/8] mptcp: fix TFO SIOCINQ overflow in mptcp_inq_hint Geliang Tang
2026-11-19  5:26   ` sashiko-bot
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 3/8] mptcp: drop the mptcp_ooo_try_coalesce() helper Geliang Tang
2026-11-19  5:10 ` [PATCH mptcp-next v29 4/8] mptcp: drop the cant_coalesce CB field Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko [this message]
2026-11-19  5:10 ` [PATCH mptcp-next v29 5/8] mptcp: encapsulate CB DSN field access with helpers Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 6/8] mptcp: remove CB offset field Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 7/8] mptcp: sync mptcp skb cb layout with tcp one Geliang Tang
2026-11-19  5:43   ` sashiko-bot
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 8/8] mptcp: defer read_sock cleanup to mptcp_worker Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179520011006.3133.16319687060684256580@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=geliang@kernel.org \
    --cc=kuba@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.