All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: geliang@kernel.org
Cc: mptcp@lists.linux.dev, kuba@kernel.org
Subject: Re: [PATCH mptcp-next v29 5/8] mptcp: encapsulate CB DSN field access with helpers
Date: Fri, 20 Nov 2026 18:41:51 +0000	[thread overview]
Message-ID: <179520011112.3133.14475010950011269195@kernel.org> (raw)
In-Reply-To: <93f8727507735aefbf0794b1af5b555993249a5e.1795063943.git.tanggeliang@kylinos.cn>

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The From:/Signed-off-by: identities don't match in commit "mptcp:
  encapsulate CB DSN field access with helpers".

--

mptcp: encapsulate CB DSN field access with helpers

This commit adds the mptcp_dsn() and mptcp_end_dsn() helpers. They return
the start and end DSN from the MPTCP skb CB. Direct accesses to
MPTCP_SKB_CB(skb)->map_seq and end_seq in protocol.c and in the
mptcp_rcvbuf_grow tracepoint now go through these helpers, so the CB
layout can change in later commits.

> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>

[Severity: Low]
This isn't a bug, but the author address and the sign-off address don't
match. The commit author is:

  Author: Geliang Tang <geliang@kernel.org>

The only trailer is:

  Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>

No Signed-off-by uses the author address. checkpatch.pl reports this as
FROM_SIGN_OFF_MISMATCH. Documentation/process/submitting-patches.rst
expects the author to sign off.

The series isn't consistent about this either. "mptcp: remove CB offset
field" and "mptcp: sync mptcp skb cb layout with tcp one" use
Signed-off-by: Geliang Tang <geliang@kernel.org>. This patch, "mptcp:
clear rcv_data_fin_seq in mptcp_disconnect" and "mptcp: defer read_sock
cleanup to mptcp_worker" sign off only with the kylinos.cn address.

Could a Signed-off-by for the kernel.org address be added, or the From:
header be changed to the kylinos.cn address?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1795063943.git.tanggeliang%40kylinos.cn

  reply	other threads:[~2026-11-20 18:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  5:10 [PATCH mptcp-next v29 0/8] Reduce the differences between TCP and MPTCP for TLS usage Geliang Tang
2026-11-19  5:10 ` [PATCH mptcp-net v29 1/8] mptcp: clear rcv_data_fin_seq in mptcp_disconnect Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-net v29 2/8] mptcp: fix TFO SIOCINQ overflow in mptcp_inq_hint Geliang Tang
2026-11-19  5:26   ` sashiko-bot
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 3/8] mptcp: drop the mptcp_ooo_try_coalesce() helper Geliang Tang
2026-11-19  5:10 ` [PATCH mptcp-next v29 4/8] mptcp: drop the cant_coalesce CB field Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 5/8] mptcp: encapsulate CB DSN field access with helpers Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko [this message]
2026-11-19  5:10 ` [PATCH mptcp-next v29 6/8] mptcp: remove CB offset field Geliang Tang
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 7/8] mptcp: sync mptcp skb cb layout with tcp one Geliang Tang
2026-11-19  5:43   ` sashiko-bot
2026-11-20 18:41   ` netdev-bot+sashiko
2026-11-19  5:10 ` [PATCH mptcp-next v29 8/8] mptcp: defer read_sock cleanup to mptcp_worker Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179520011112.3133.14475010950011269195@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=geliang@kernel.org \
    --cc=kuba@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.