From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated
Date: Fri, 24 Oct 2014 09:54:08 +0000 [thread overview]
Message-ID: <1796959.xTvOMRAxHJ@avalon> (raw)
In-Reply-To: <20141024025014.GA15243@js1304-P5Q-DELUXE>
Hello,
On Friday 24 October 2014 11:50:14 Joonsoo Kim wrote:
> On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote:
> > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart wrote:
> > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote:
> > >> On Thu, Oct 23 2014, Laurent Pinchart wrote:
> > >> > If activation of the CMA area fails its mutex won't be initialized,
> > >> > leading to an oops at allocation time when trying to lock the mutex.
> > >> > Fix this by failing allocation if the area hasn't been successfully
> > >> > actived, and detect that condition by moving the CMA bitmap
> > >> > allocation after page block reservation completion.
> > >> >
> > >> > Signed-off-by: Laurent Pinchart
> > >> > <laurent.pinchart+renesas@ideasonboard.com>
> > >>
> > >> Cc: <stable@vger.kernel.org> # v3.17
> > >> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> >
> > This patch is good, but how about add a active field in cma struct?
> > use cma->active to check whether cma is actived successfully.
> > I think it will make code more clear and readable.
> > Just my little opinion.
>
> Or just setting cma->count to 0 would work fine.
I would prefer setting cma->count to 0 to avoid the extra field. I'll modify
the patch accordingly.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated
Date: Fri, 24 Oct 2014 12:54:08 +0300 [thread overview]
Message-ID: <1796959.xTvOMRAxHJ@avalon> (raw)
In-Reply-To: <20141024025014.GA15243@js1304-P5Q-DELUXE>
Hello,
On Friday 24 October 2014 11:50:14 Joonsoo Kim wrote:
> On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote:
> > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart wrote:
> > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote:
> > >> On Thu, Oct 23 2014, Laurent Pinchart wrote:
> > >> > If activation of the CMA area fails its mutex won't be initialized,
> > >> > leading to an oops at allocation time when trying to lock the mutex.
> > >> > Fix this by failing allocation if the area hasn't been successfully
> > >> > actived, and detect that condition by moving the CMA bitmap
> > >> > allocation after page block reservation completion.
> > >> >
> > >> > Signed-off-by: Laurent Pinchart
> > >> > <laurent.pinchart+renesas@ideasonboard.com>
> > >>
> > >> Cc: <stable@vger.kernel.org> # v3.17
> > >> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> >
> > This patch is good, but how about add a active field in cma struct?
> > use cma->active to check whether cma is actived successfully.
> > I think it will make code more clear and readable.
> > Just my little opinion.
>
> Or just setting cma->count to 0 would work fine.
I would prefer setting cma->count to 0 to avoid the extra field. I'll modify
the patch accordingly.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Weijie Yang <weijie.yang.kh@gmail.com>,
Michal Nazarewicz <mina86@mina86.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated
Date: Fri, 24 Oct 2014 12:54:08 +0300 [thread overview]
Message-ID: <1796959.xTvOMRAxHJ@avalon> (raw)
In-Reply-To: <20141024025014.GA15243@js1304-P5Q-DELUXE>
Hello,
On Friday 24 October 2014 11:50:14 Joonsoo Kim wrote:
> On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote:
> > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart wrote:
> > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote:
> > >> On Thu, Oct 23 2014, Laurent Pinchart wrote:
> > >> > If activation of the CMA area fails its mutex won't be initialized,
> > >> > leading to an oops at allocation time when trying to lock the mutex.
> > >> > Fix this by failing allocation if the area hasn't been successfully
> > >> > actived, and detect that condition by moving the CMA bitmap
> > >> > allocation after page block reservation completion.
> > >> >
> > >> > Signed-off-by: Laurent Pinchart
> > >> > <laurent.pinchart+renesas@ideasonboard.com>
> > >>
> > >> Cc: <stable@vger.kernel.org> # v3.17
> > >> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> >
> > This patch is good, but how about add a active field in cma struct?
> > use cma->active to check whether cma is actived successfully.
> > I think it will make code more clear and readable.
> > Just my little opinion.
>
> Or just setting cma->count to 0 would work fine.
I would prefer setting cma->count to 0 to avoid the extra field. I'll modify
the patch accordingly.
--
Regards,
Laurent Pinchart
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Weijie Yang <weijie.yang.kh@gmail.com>,
Michal Nazarewicz <mina86@mina86.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated
Date: Fri, 24 Oct 2014 12:54:08 +0300 [thread overview]
Message-ID: <1796959.xTvOMRAxHJ@avalon> (raw)
In-Reply-To: <20141024025014.GA15243@js1304-P5Q-DELUXE>
Hello,
On Friday 24 October 2014 11:50:14 Joonsoo Kim wrote:
> On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote:
> > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart wrote:
> > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote:
> > >> On Thu, Oct 23 2014, Laurent Pinchart wrote:
> > >> > If activation of the CMA area fails its mutex won't be initialized,
> > >> > leading to an oops at allocation time when trying to lock the mutex.
> > >> > Fix this by failing allocation if the area hasn't been successfully
> > >> > actived, and detect that condition by moving the CMA bitmap
> > >> > allocation after page block reservation completion.
> > >> >
> > >> > Signed-off-by: Laurent Pinchart
> > >> > <laurent.pinchart+renesas@ideasonboard.com>
> > >>
> > >> Cc: <stable@vger.kernel.org> # v3.17
> > >> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> >
> > This patch is good, but how about add a active field in cma struct?
> > use cma->active to check whether cma is actived successfully.
> > I think it will make code more clear and readable.
> > Just my little opinion.
>
> Or just setting cma->count to 0 would work fine.
I would prefer setting cma->count to 0 to avoid the extra field. I'll modify
the patch accordingly.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-10-24 9:54 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 14:33 [PATCH 0/4] Low/high memory CMA reservation fixes Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 16:53 ` Michal Nazarewicz
2014-10-23 16:53 ` Michal Nazarewicz
2014-10-23 16:53 ` Michal Nazarewicz
2014-10-23 16:53 ` Michal Nazarewicz
2014-10-23 23:42 ` Laurent Pinchart
2014-10-23 23:42 ` Laurent Pinchart
2014-10-23 23:42 ` Laurent Pinchart
2014-10-23 23:42 ` Laurent Pinchart
2014-10-24 2:02 ` Weijie Yang
2014-10-24 2:02 ` Weijie Yang
2014-10-24 2:02 ` Weijie Yang
2014-10-24 2:02 ` Weijie Yang
2014-10-24 2:50 ` Joonsoo Kim
2014-10-24 2:50 ` Joonsoo Kim
2014-10-24 2:50 ` Joonsoo Kim
2014-10-24 9:54 ` Laurent Pinchart [this message]
2014-10-24 9:54 ` Laurent Pinchart
2014-10-24 9:54 ` Laurent Pinchart
2014-10-24 9:54 ` Laurent Pinchart
2014-10-24 16:34 ` Michal Nazarewicz
2014-10-24 16:34 ` Michal Nazarewicz
2014-10-24 16:34 ` Michal Nazarewicz
2014-10-24 16:34 ` Michal Nazarewicz
2014-10-23 14:33 ` [PATCH 2/4] mm: cma: Always consider a 0 base address reservation as dynamic Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 16:55 ` Michal Nazarewicz
2014-10-23 16:55 ` Michal Nazarewicz
2014-10-23 16:55 ` Michal Nazarewicz
2014-10-23 16:55 ` Michal Nazarewicz
2014-10-23 23:50 ` Laurent Pinchart
2014-10-23 23:50 ` Laurent Pinchart
2014-10-23 23:50 ` Laurent Pinchart
2014-10-23 23:50 ` Laurent Pinchart
2014-10-23 14:33 ` [PATCH 3/4] mm: cma: Ensure that reservations never cross the low/high mem boundary Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-24 2:53 ` Joonsoo Kim
2014-10-24 2:53 ` Joonsoo Kim
2014-10-24 2:53 ` Joonsoo Kim
2014-10-24 10:00 ` Laurent Pinchart
2014-10-24 10:00 ` Laurent Pinchart
2014-10-24 10:00 ` Laurent Pinchart
2014-10-24 10:00 ` Laurent Pinchart
2014-10-23 14:33 ` [PATCH 4/4] mm: cma: Use %pa to print physical addresses Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 14:33 ` Laurent Pinchart
2014-10-23 16:56 ` Michal Nazarewicz
2014-10-23 16:56 ` Michal Nazarewicz
2014-10-23 16:56 ` Michal Nazarewicz
2014-10-23 16:56 ` Michal Nazarewicz
2014-10-23 17:51 ` Geert Uytterhoeven
2014-10-23 17:51 ` Geert Uytterhoeven
2014-10-23 17:51 ` Geert Uytterhoeven
2014-10-23 17:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1796959.xTvOMRAxHJ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.