All of lore.kernel.org
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
Date: Tue, 06 Jan 2015 18:44:13 +0100	[thread overview]
Message-ID: <1798568.RumoICfKOO@phil> (raw)
In-Reply-To: <1418689340-29517-3-git-send-email-dianders@chromium.org>

Hi Doug,

Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson:
> Specifying these rails should eventually let us do UHS.
> 
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes in v3: None
> Changes in v2:
> - Fix subject line
> 
>  arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -114,6 +114,8 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
>  	status = "okay";
> +	vmmc-supply = <&vcc_io>;

according to the schematics there is a switch between the card and vcc_io with 
a controlling pin called SDMMC_PWR providing a supply called vcc_sd.

So there should probably be a fixed-regulator get introduced for this, like the 
older rockchip boards do.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux@arm.linux.org.uk, Alexandru Stan <amstan@chromium.org>,
	pawel.moll@arm.com, linux-rockchip@lists.infradead.org,
	Seungwon Jeon <tgih.jun@samsung.com>,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, Jaehoon Chung <jh80.chung@samsung.com>,
	Andrew Bresticker <abrestic@chromium.org>,
	Mark Brown <broonie@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	galak@codeaurora.org, Sonny Rao <sonnyrao@chromium.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
Date: Tue, 06 Jan 2015 18:44:13 +0100	[thread overview]
Message-ID: <1798568.RumoICfKOO@phil> (raw)
In-Reply-To: <1418689340-29517-3-git-send-email-dianders@chromium.org>

Hi Doug,

Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson:
> Specifying these rails should eventually let us do UHS.
> 
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes in v3: None
> Changes in v2:
> - Fix subject line
> 
>  arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -114,6 +114,8 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
>  	status = "okay";
> +	vmmc-supply = <&vcc_io>;

according to the schematics there is a switch between the card and vcc_io with 
a controlling pin called SDMMC_PWR providing a supply called vcc_sd.

So there should probably be a fixed-regulator get introduced for this, like the 
older rockchip boards do.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Seungwon Jeon <tgih.jun@samsung.com>,
	Mark Brown <broonie@kernel.org>,
	Alexandru Stan <amstan@chromium.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Sonny Rao <sonnyrao@chromium.org>,
	Andrew Bresticker <abrestic@chromium.org>,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux@arm.linux.org.uk, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
Date: Tue, 06 Jan 2015 18:44:13 +0100	[thread overview]
Message-ID: <1798568.RumoICfKOO@phil> (raw)
In-Reply-To: <1418689340-29517-3-git-send-email-dianders@chromium.org>

Hi Doug,

Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson:
> Specifying these rails should eventually let us do UHS.
> 
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes in v3: None
> Changes in v2:
> - Fix subject line
> 
>  arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -114,6 +114,8 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
>  	status = "okay";
> +	vmmc-supply = <&vcc_io>;

according to the schematics there is a switch between the card and vcc_io with 
a controlling pin called SDMMC_PWR providing a supply called vcc_sd.

So there should probably be a fixed-regulator get introduced for this, like the 
older rockchip boards do.


Heiko

  reply	other threads:[~2015-01-06 17:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-16  0:22 [PATCH v3 1/3] mmc: core: Add mmc_regulator_set_vqmmc() Doug Anderson
2014-12-16  0:22 ` Doug Anderson
2014-12-16  0:22 ` [PATCH v3 2/3] mmc: dw_mmc: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch Doug Anderson
2014-12-16  0:22   ` Doug Anderson
2014-12-16  1:12   ` Andrew Bresticker
2014-12-16  1:12     ` Andrew Bresticker
2014-12-16  0:22 ` [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb Doug Anderson
2014-12-16  0:22   ` Doug Anderson
2015-01-06 17:44   ` Heiko Stübner [this message]
2015-01-06 17:44     ` Heiko Stübner
2015-01-06 17:44     ` Heiko Stübner
2015-03-11 22:13     ` Doug Anderson
2015-03-11 22:13       ` Doug Anderson
2015-03-11 22:13       ` Doug Anderson
2015-02-25 20:23 ` [PATCH v3 1/3] mmc: core: Add mmc_regulator_set_vqmmc() Doug Anderson
2015-02-25 20:23   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1798568.RumoICfKOO@phil \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.