Re: [PATCH 1/2] ASoC: Intel: avs: Synchronize happy and error paths in PCI probe

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2025-07-29 1:47 PM, Mark Brown wrote:
> On Tue, Jul 29, 2025 at 01:42:28PM +0200, Cezary Rojewski wrote:
> 
>>   err_i915_init:
>> -	pci_free_irq(pci, 0, adev);
>> -	pci_free_irq(pci, 0, bus);
>> -	pci_free_irq_vectors(pci);
>> -	pci_clear_master(pci);
>>   	pci_set_drvdata(pci, NULL);
>> +	pci_clear_master(pci);
>> +	pci_free_irq(pci, 0, adev);
>> +	pci_free_irq(pci, 0, bus);
>> +	pci_free_irq_vectors(pci);
> 
> The ordering before clearing the driver data actually looks sensible
> there, though looking at the interrupt handlers quickly they don't seem
> to pay attention to driver data.  Really you could just delete the
> pci_set_drvdata(), it should be redundant (and IIRC the driver core does
> that anyway).

While I do agree that pci_set_drvdata(NULL) could be skipped, I feel 
better with having a true reverse order in the error path:

happy path:
	pci_alloc_irq_vectors();
	pci_request_irq(bus);
	pci_request_irq(adev);
	pci_set_master();


error path:
	pci_clear_master(pci);
	pci_free_irq(pci, 0, adev);
	pci_free_irq(pci, 0, bus);
	pci_free_irq_vectors(pci);

Is there anything wrong with the approach before I send v2?