Re: [PATCH 1/2] ASoC: Intel: avs: Synchronize happy and error paths in PCI probe

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2025-07-29 3:32 PM, Mark Brown wrote:
> On Tue, Jul 29, 2025 at 02:49:18PM +0200, Cezary Rojewski wrote:
> 
>> happy path:
>> 	pci_alloc_irq_vectors();
>> 	pci_request_irq(bus);
>> 	pci_request_irq(adev);
>> 	pci_set_master();
> 
>> error path:
>> 	pci_clear_master(pci);
>> 	pci_free_irq(pci, 0, adev);
>> 	pci_free_irq(pci, 0, bus);
>> 	pci_free_irq_vectors(pci);
> 
>> Is there anything wrong with the approach before I send v2?
> 
> Unless there's some issue with having master disabled but interrupts
> disabled that should be fine.

After your comments, I've investigated the drivers/ code and it seems 
it's more common to put pci_set_master() early in the probe() rather 
than at the end of it. That may trigger an update to avs/ and would 
render this very patch redundant.

Because of that, I've decided to drop this patch. Will re-iterate on the 
subject but don't want to block the followup patch.

Good review Mark!