From: David Laight <David.Laight@ACULAB.COM>
To: "'Cezary Rojewski'" <cezary.rojewski@intel.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
"amadeuszx.slawinski@linux.intel.com"
<amadeuszx.slawinski@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Subject: RE: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
Date: Wed, 13 Jul 2022 09:14:09 +0000 [thread overview]
Message-ID: <17c91bfb3a864ae1be2ac3226f170f55@AcuMS.aculab.com> (raw)
In-Reply-To: <e2fe6351-f9ee-48eb-ad7f-280249f7f3f7@intel.com>
> if (pint)
> - *pint = value;
> + memcpy(pint, &value, min(nsize, sizeof(value)));
That is just soooooo broken.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: "'Cezary Rojewski'" <cezary.rojewski@intel.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Mark Brown <broonie@kernel.org>,
"ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
"amadeuszx.slawinski@linux.intel.com"
<amadeuszx.slawinski@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Subject: RE: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
Date: Wed, 13 Jul 2022 09:14:09 +0000 [thread overview]
Message-ID: <17c91bfb3a864ae1be2ac3226f170f55@AcuMS.aculab.com> (raw)
In-Reply-To: <e2fe6351-f9ee-48eb-ad7f-280249f7f3f7@intel.com>
> if (pint)
> - *pint = value;
> + memcpy(pint, &value, min(nsize, sizeof(value)));
That is just soooooo broken.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-07-13 9:15 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 9:13 [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32() Cezary Rojewski
2022-07-07 9:13 ` Cezary Rojewski
2022-07-07 9:13 ` [PATCH 2/2] ASoC: SOF: Remove tokenize_input() Cezary Rojewski
2022-07-07 9:13 ` Cezary Rojewski
2022-07-07 13:51 ` [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32() Péter Ujfalusi
2022-07-07 13:51 ` Péter Ujfalusi
2022-07-08 11:33 ` Cezary Rojewski
2022-07-08 11:33 ` Cezary Rojewski
2022-07-08 10:22 ` Andy Shevchenko
2022-07-08 10:22 ` Andy Shevchenko
2022-07-08 11:29 ` Andy Shevchenko
2022-07-08 11:29 ` Andy Shevchenko
2022-07-08 11:32 ` Cezary Rojewski
2022-07-08 11:32 ` Cezary Rojewski
2022-07-08 11:46 ` Andy Shevchenko
2022-07-08 11:46 ` Andy Shevchenko
2022-07-08 11:51 ` Andy Shevchenko
2022-07-08 11:51 ` Andy Shevchenko
2022-07-08 12:13 ` Cezary Rojewski
2022-07-08 12:13 ` Cezary Rojewski
2022-07-08 12:30 ` Andy Shevchenko
2022-07-08 12:30 ` Andy Shevchenko
2022-07-08 12:35 ` Péter Ujfalusi
2022-07-08 12:35 ` Péter Ujfalusi
2022-07-08 15:25 ` Andy Shevchenko
2022-07-08 15:25 ` Andy Shevchenko
2022-07-08 15:28 ` Andy Shevchenko
2022-07-08 15:28 ` Andy Shevchenko
2022-07-08 16:32 ` Cezary Rojewski
2022-07-08 16:32 ` Cezary Rojewski
2022-07-08 16:49 ` Andy Shevchenko
2022-07-08 16:49 ` Andy Shevchenko
2022-07-09 8:45 ` Cezary Rojewski
2022-07-09 8:45 ` Cezary Rojewski
2022-07-09 20:42 ` Andy Shevchenko
2022-07-09 20:42 ` Andy Shevchenko
2022-07-12 13:51 ` Cezary Rojewski
2022-07-12 13:51 ` Cezary Rojewski
2022-07-12 13:59 ` Andy Shevchenko
2022-07-12 13:59 ` Andy Shevchenko
2022-07-12 14:02 ` Mark Brown
2022-07-12 14:02 ` Mark Brown
2022-07-12 14:24 ` Andy Shevchenko
2022-07-12 14:24 ` Andy Shevchenko
2022-07-19 11:40 ` Cezary Rojewski
2022-07-19 11:40 ` Cezary Rojewski
2022-08-09 9:55 ` Cezary Rojewski
2022-08-09 9:55 ` Cezary Rojewski
2022-08-09 15:23 ` Andy Shevchenko
2022-08-09 15:23 ` Andy Shevchenko
2022-08-16 9:28 ` Cezary Rojewski
2022-08-16 9:28 ` Cezary Rojewski
2022-08-25 15:09 ` Andy Shevchenko
2022-08-25 15:09 ` Andy Shevchenko
2022-08-25 16:44 ` Cezary Rojewski
2022-08-25 16:44 ` Cezary Rojewski
2022-07-13 9:14 ` David Laight [this message]
2022-07-13 9:14 ` David Laight
2022-07-13 9:38 ` Andy Shevchenko
2022-07-13 9:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17c91bfb3a864ae1be2ac3226f170f55@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.