Re: [PATCH 2/2] NFS: Error when mounting the same filesystem with different options

[Neil Brown <neilb@suse.de>]

On Wednesday May 16, Trond.Myklebust@netapp.com wrote:
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
> 
> Unless the user sets the NFS_MOUNT_NOSHAREDCACHE mount flag, we should
> return EBUSY if the filesystem is already mounted on a superblock that
> has set conflicting mount options.

I'm not very comfortable with the EBUSY return.
This is something that I would really like "mount.nfs" to be aware of
and at least produce useful error messages about.
So it would be very nice to have a unique error code.

But it is not at all obvious what error code could be used.
EEXIST possibly comes closes to the write meaning.
The man page for mount doesn't list EEXIST as an option, but says:
   Each  filesystem type may have its own special errors and its
   own special behavior.

so that might be OK.

Would you be agreeable to changing the error code to EEXIST??

Then mount.nfs could suggest using "-o nosharecache" when EEXIST is
returned.

NeilBrown

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs