All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: nfs@lists.sourceforge.net
Cc: Neil Brown <neilb@suse.de>, Paul Krizak <paul.krizak@amd.com>,
	Trond Myklebust <Trond.Myklebust@netapp.com>,
	Ian Kent <raven@themaw.net>
Subject: Re: inconsistent mount attributes (ro/rw), RHEL5 / Netapp
Date: Tue, 15 May 2007 09:58:07 -0400	[thread overview]
Message-ID: <4649BC6F.2010906@oracle.com> (raw)
In-Reply-To: <1179184319.6467.7.camel@heimdal.trondhjem.org>

[-- Attachment #1: Type: text/plain, Size: 2411 bytes --]

Disclaimer:

As Trond knows, I don't like the current "shared cache" implementation, 
even given the security issue of mounting the same file system with 
AUTH_SYS and AUTH_GSS.

See response below.

Trond Myklebust wrote:
> On Tue, 2007-05-15 at 08:41 +1000, Neil Brown wrote:
>> I think "shared" is an important concept to have in there as it is
>> sharing the cache, the connection and the options.  For consistency
>> with other options, I would have an optional "no" at the front to
>> invert the flag.  Current nfs options don't have punctuation, so I
>> would probably go for something like:
>>        -o  [no]sharedcache
>>        -o  [no]shareconnection 
>>
>> Then comes the question of what the default should be.
>> The original default was nosharedcache, but the more recent default
>> has been sharedcache.   In hindsight it would have been better not to
>> change the default, but things are always much clearer in hindsight.
>>
>> I would lean towards restoring the default to nosharedcache, and
>> having to explicitly request sharedcache if you want that, and are
>> happy to have the same mount option enforced on all sharing mounts.
> 
> I disagree with that. The default was changed for a very good reason,
> namely that people were making assumptions that were wrong: i.e. that
> the cache remains consistent when you change the ro/rw flag or try to
> mount a subdirectory.
> In fact, if you mounted the _same_ directory twice, then the default was
> always 'sharedcache'.
> 
> So all we did in 2.6.18, was to make a consistent set of rules for how
> this works.
> 
> The default should therefore remain 'sharedcache', preferably returning
> an error if the user tries to mix metaphors.

There have always been reasonable use cases (OK, well, reasonable to me 
anyway) for having completely separate options and caches for each NFS 
mount.  Another way to look at this is that "sharedcache" is really 
giving you "mount --bind" and not just a "mount".  Therefore all this 
can be mimicked in user space.

Just kicking it out there: why not revert the kernel back to the 
previous state of affairs where "nosharedcache" was the default, and 
then let user space handle sharing or not sharing, documenting clearly 
what the implications are in the mount(8) or nfs(5) man pages?  User 
space is smart enough to emit a warning about mixing security flavors, 
for instance, as suggested above.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 291 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel/
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  parent reply	other threads:[~2007-05-15 14:00 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-18 21:53 inconsistent mount attributes (ro/rw), RHEL5 / Netapp Gregory Baker
     [not found] ` <1176948355.6422.72.camel@heimdal.trondhjem.org>
2007-04-19 18:24   ` Gregory Baker
2007-04-19 18:31     ` Trond Myklebust
2007-04-19 20:37       ` Gregory Baker
2007-04-19 22:11         ` Trond Myklebust
2007-04-19 22:23           ` Gregory Baker
2007-04-23 18:36             ` Gregory Baker
2007-04-24 19:57               ` Gregory Baker
2007-04-24 22:01                 ` Gregory Baker
2007-05-04 20:30               ` Gregory Baker
2007-05-04 21:41                 ` Trond Myklebust
2007-05-05 15:37                   ` Ian Kent
2007-05-05 17:17                     ` Trond Myklebust
2007-05-05 18:27                       ` Ian Kent
2007-05-05 18:49                         ` Trond Myklebust
2007-05-06  4:51                           ` Ian Kent
2007-05-14 13:17                       ` Karel Zak
2007-05-14 13:24                         ` Trond Myklebust
2007-05-14 14:39                           ` Ian Kent
2007-05-14 15:47                             ` Trond Myklebust
2007-05-14 15:56                               ` Paul Krizak
2007-05-14 16:06                                 ` Trond Myklebust
2007-05-14 16:06                               ` Ian Kent
2007-05-14 22:41                                 ` Neil Brown
2007-05-14 23:11                                   ` Trond Myklebust
2007-05-14 23:58                                     ` Neil Brown
2007-05-16  0:27                                       ` Trond Myklebust
2007-05-16  1:36                                       ` [PATCH 1/2] NFS: Add the mount option nosharedcache Trond Myklebust
2007-05-16  3:46                                         ` Neil Brown
2007-05-16 13:22                                           ` Trond Myklebust
2007-05-17  2:13                                           ` [PATCH 1/2] NFS: Add the mount option "nosharecache" Trond Myklebust
2007-05-18  3:12                                             ` Ian Kent
2007-05-18 13:20                                               ` Trond Myklebust
2007-05-18 14:57                                                 ` Ian Kent
2007-05-17  2:13                                           ` [PATCH] mount.nfs: Add support for the 'nosharecache' option Trond Myklebust
2007-05-17  2:13                                           ` [PATCH 2/2] NFS: Error when mounting the same filesystem with different options Trond Myklebust
2007-05-29  2:35                                             ` Neil Brown
2007-06-05 23:49                                               ` Trond Myklebust
2007-05-16  1:37                                       ` Trond Myklebust
2007-05-15 13:58                                     ` Chuck Lever [this message]
2007-05-15 14:33                                       ` inconsistent mount attributes (ro/rw), RHEL5 / Netapp Trond Myklebust
2007-05-15 16:57                                     ` Gregory Baker
2007-05-14 14:30                         ` Ian Kent
2007-05-14 13:03                     ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4649BC6F.2010906@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    --cc=paul.krizak@amd.com \
    --cc=raven@themaw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.