All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Andi Shyti <andi.shyti@kernel.org>,
	"moderated list:ARM/Rockchip SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support"
	<linux-rockchip@lists.infradead.org>,
	"open list:I2C SUBSYSTEM HOST DRIVERS"
	<linux-i2c@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Anand Moon <linux.amoon@gmail.com>
Cc: Anand Moon <linux.amoon@gmail.com>, David Wu <david.wu@rock-chips.com>
Subject: Re: [PATCH v1] i2c: rk3x: Add support for SCL output enable debounce
Date: Sat, 03 Jan 2026 11:39:40 +0100	[thread overview]
Message-ID: <1802774.yIU609i1g2@diego> (raw)
In-Reply-To: <20260103052506.6743-1-linux.amoon@gmail.com>

Am Samstag, 3. Januar 2026, 06:25:04 Mitteleuropäische Normalzeit schrieb Anand Moon:
> From: David Wu <david.wu@rock-chips.com>
> 
> As per the RK3399 and RK3588 datasheets Rockchip I2C controllers feature
> a SCL_OE_DB register (0x24). This register is used to configure the
> debounce time for the SCL output enable signal, which helps prevent
> glitches and ensures timing compliance during bus handover or slave clock
> stretching.
> 
> Introduce a 'has_scl_oe_debounce' flag to rk3x_i2c_soc_data to
> distinguish between hardware versions. For supported SoCs, calculate
> the debounce counter dynamically based on the current clock rate
> and program it during divider adaptation.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Signed-off-by: David Wu <david.wu@rock-chips.com>

Signed-off-by lines are in the wrong order.

Original author first, then yours as you're the one handling
the patch last.


Also, does this fix a problem for you, or is this more a case of
"this looks useful"?

Thanks
Heiko





WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Andi Shyti <andi.shyti@kernel.org>,
	"moderated list:ARM/Rockchip SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support"
	<linux-rockchip@lists.infradead.org>,
	"open list:I2C SUBSYSTEM HOST DRIVERS"
	<linux-i2c@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Anand Moon <linux.amoon@gmail.com>
Cc: Anand Moon <linux.amoon@gmail.com>, David Wu <david.wu@rock-chips.com>
Subject: Re: [PATCH v1] i2c: rk3x: Add support for SCL output enable debounce
Date: Sat, 03 Jan 2026 11:39:40 +0100	[thread overview]
Message-ID: <1802774.yIU609i1g2@diego> (raw)
In-Reply-To: <20260103052506.6743-1-linux.amoon@gmail.com>

Am Samstag, 3. Januar 2026, 06:25:04 Mitteleuropäische Normalzeit schrieb Anand Moon:
> From: David Wu <david.wu@rock-chips.com>
> 
> As per the RK3399 and RK3588 datasheets Rockchip I2C controllers feature
> a SCL_OE_DB register (0x24). This register is used to configure the
> debounce time for the SCL output enable signal, which helps prevent
> glitches and ensures timing compliance during bus handover or slave clock
> stretching.
> 
> Introduce a 'has_scl_oe_debounce' flag to rk3x_i2c_soc_data to
> distinguish between hardware versions. For supported SoCs, calculate
> the debounce counter dynamically based on the current clock rate
> and program it during divider adaptation.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Signed-off-by: David Wu <david.wu@rock-chips.com>

Signed-off-by lines are in the wrong order.

Original author first, then yours as you're the one handling
the patch last.


Also, does this fix a problem for you, or is this more a case of
"this looks useful"?

Thanks
Heiko




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-01-03 10:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-03  5:25 [PATCH v1] i2c: rk3x: Add support for SCL output enable debounce Anand Moon
2026-01-03  5:25 ` Anand Moon
2026-01-03 10:39 ` Heiko Stübner [this message]
2026-01-03 10:39   ` Heiko Stübner
2026-01-03 11:56   ` Anand Moon
2026-01-03 11:56     ` Anand Moon
2026-01-10 10:59 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1802774.yIU609i1g2@diego \
    --to=heiko@sntech.de \
    --cc=andi.shyti@kernel.org \
    --cc=david.wu@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux.amoon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.