From: Heiko Stuebner <heiko@sntech.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Enric Balletbo Serra <eballetbo@gmail.com>,
Elaine Zhang <zhangqing@rock-chips.com>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
huangtao@rock-chips.com, Linux PM list <linux-pm@vger.kernel.org>,
xxx@rock-chips.com, xf@rock-chips.com,
linux-kernel <linux-kernel@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Doug Anderson <dianders@chromium.org>,
vicencb@gmail.com
Subject: Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error
Date: Wed, 22 May 2019 14:34:58 +0200 [thread overview]
Message-ID: <1805430.MCm2xJzUXA@phil> (raw)
In-Reply-To: <f0581341-126a-5733-3c4b-8e6f67bfc32e@linaro.org>
Am Mittwoch, 22. Mai 2019, 14:30:16 CEST schrieb Daniel Lezcano:
> On 22/05/2019 14:27, Heiko Stuebner wrote:
>
> [ ... ]
>
> >> As this change is now in mainline and is causing veyron to hang I'd
> >> suggest reverting this change for now. Even fixing the root cause
> >> (maybe the one I pointed above) after this patch we will have the
> >> thermal driver to fail because "gpio" and "otpout" states are not
> >> defined nor documented (a change on this will need some reviews and
> >> acks and time I guess).
> >
> > I definitly agree here. Handling + checking the binding change
> > as well as needed fallback code is definitly not material for -rc-kernels
> > so we should just revert for now and let Elaine fix the issues for 5.3.
> >
> > Anyone volunteering for sending a revert-patch to Eduardo? :-)
>
> I can't right now :/
ok, I'll do the revert patch then, so that we get this sorted.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
huangtao@rock-chips.com, Doug Anderson <dianders@chromium.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Enric Balletbo Serra <eballetbo@gmail.com>,
xxx@rock-chips.com, Elaine Zhang <zhangqing@rock-chips.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
vicencb@gmail.com, xf@rock-chips.com,
Eduardo Valentin <edubezval@gmail.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error
Date: Wed, 22 May 2019 14:34:58 +0200 [thread overview]
Message-ID: <1805430.MCm2xJzUXA@phil> (raw)
In-Reply-To: <f0581341-126a-5733-3c4b-8e6f67bfc32e@linaro.org>
Am Mittwoch, 22. Mai 2019, 14:30:16 CEST schrieb Daniel Lezcano:
> On 22/05/2019 14:27, Heiko Stuebner wrote:
>
> [ ... ]
>
> >> As this change is now in mainline and is causing veyron to hang I'd
> >> suggest reverting this change for now. Even fixing the root cause
> >> (maybe the one I pointed above) after this patch we will have the
> >> thermal driver to fail because "gpio" and "otpout" states are not
> >> defined nor documented (a change on this will need some reviews and
> >> acks and time I guess).
> >
> > I definitly agree here. Handling + checking the binding change
> > as well as needed fallback code is definitly not material for -rc-kernels
> > so we should just revert for now and let Elaine fix the issues for 5.3.
> >
> > Anyone volunteering for sending a revert-patch to Eduardo? :-)
>
> I can't right now :/
ok, I'll do the revert patch then, so that we get this sorted.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-22 12:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 10:09 [PATCH v3 0/3] thermal: rockchip: fix up thermal driver Elaine Zhang
2019-04-30 10:09 ` Elaine Zhang
2019-04-30 10:09 ` [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error Elaine Zhang
2019-04-30 10:09 ` Elaine Zhang
2019-04-30 13:38 ` Daniel Lezcano
2019-04-30 13:38 ` Daniel Lezcano
2019-05-20 13:38 ` Enric Balletbo Serra
2019-05-20 13:38 ` Enric Balletbo Serra
2019-05-22 12:27 ` Heiko Stuebner
2019-05-22 12:27 ` Heiko Stuebner
2019-05-22 12:30 ` Daniel Lezcano
2019-05-22 12:30 ` Daniel Lezcano
2019-05-22 12:34 ` Heiko Stuebner [this message]
2019-05-22 12:34 ` Heiko Stuebner
2019-05-23 1:34 ` elaine.zhang
2019-05-23 1:34 ` elaine.zhang
2019-05-24 2:23 ` Eduardo Valentin
2019-05-24 2:23 ` Eduardo Valentin
2019-05-24 6:45 ` Heiko Stuebner
2019-05-24 6:45 ` Heiko Stuebner
2019-05-22 12:20 ` Daniel Lezcano
2019-05-22 12:20 ` Daniel Lezcano
2019-04-30 10:09 ` [PATCH v3 2/3] dt-bindings: rockchip-thermal: Support the PX30 SoC compatible Elaine Zhang
2019-04-30 10:09 ` Elaine Zhang
2019-04-30 10:09 ` [PATCH v3 3/3] thermal: rockchip: Support the PX30 SoC in thermal driver Elaine Zhang
2019-04-30 10:09 ` Elaine Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1805430.MCm2xJzUXA@phil \
--to=heiko@sntech.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=eballetbo@gmail.com \
--cc=edubezval@gmail.com \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vicencb@gmail.com \
--cc=xf@rock-chips.com \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.