From: Heiko Stuebner <heiko@sntech.de>
To: Damian Kos <dkos@cadence.com>
Cc: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Gustavo Padovan <gustavo@padovan.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>, Sandy Huang <hjc@rock-chips.com>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, pgaj@cadence.com,
ltyrala@cadence.com, rafalc@cadence.com, jartur@cadence.com,
piotrs@cadence.com, quentin.schulz@bootlin.com,
jbergsagel@ti.com
Subject: Re: [PATCH v5 2/5] drm/dp: fix link probing for devices supporting DP 1.4+
Date: Tue, 25 Sep 2018 13:18:42 +0200 [thread overview]
Message-ID: <18095829.BFmvNaydv0@phil> (raw)
In-Reply-To: <1537866837-4408-3-git-send-email-dkos@cadence.com>
Hi Damian,
Am Dienstag, 25. September 2018, 11:13:32 CEST schrieb Damian Kos:
> From: Quentin Schulz <quentin.schulz@free-electrons.com>
>
> DP 1.4 introduced a DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit in
> DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from
> DP_DPCD_REV to DP_ADAPTER_CAP should be retrieved starting from
> DP_DPCD_REV_EXTENDED. All registers are copied except DP_DPCD_REV,
> DP_MAX_LINK_RATE and DP_DOWNSTREAMPORT_PRESENT which represent the
> "true capabilities" of DPRX device.
>
> Original DP_DPCD_REV, DP_MAX_LINK_RATE and DP_DOWNSTREAMPORT_PRESENT
> might falsely return lower capabilities to "avoid interoperability
> issues with some of the existing DP Source devices that malfunction
> when they discover the higher capabilities within those three
> registers.".
>
> Before DP 1.4, DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit was reserved
> and read 0 so it's safe to check against it even if DP revision is
> <1.4
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> Signed-off-by: Damian Kos <dkos@cadence.com>
in v4 you received a
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
for this patch. If a patch is largely unchanged from one version to another
please add these previously received tags to the commit message.
This prevents people from reviewing needlessly stuff twice ;-) .
So the above should read
----- 8< -----
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Signed-off-by: Damian Kos <dkos@cadence.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
----- 8< -----
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/5] drm/dp: fix link probing for devices supporting DP 1.4+
Date: Tue, 25 Sep 2018 13:18:42 +0200 [thread overview]
Message-ID: <18095829.BFmvNaydv0@phil> (raw)
In-Reply-To: <1537866837-4408-3-git-send-email-dkos@cadence.com>
Hi Damian,
Am Dienstag, 25. September 2018, 11:13:32 CEST schrieb Damian Kos:
> From: Quentin Schulz <quentin.schulz@free-electrons.com>
>
> DP 1.4 introduced a DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit in
> DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from
> DP_DPCD_REV to DP_ADAPTER_CAP should be retrieved starting from
> DP_DPCD_REV_EXTENDED. All registers are copied except DP_DPCD_REV,
> DP_MAX_LINK_RATE and DP_DOWNSTREAMPORT_PRESENT which represent the
> "true capabilities" of DPRX device.
>
> Original DP_DPCD_REV, DP_MAX_LINK_RATE and DP_DOWNSTREAMPORT_PRESENT
> might falsely return lower capabilities to "avoid interoperability
> issues with some of the existing DP Source devices that malfunction
> when they discover the higher capabilities within those three
> registers.".
>
> Before DP 1.4, DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit was reserved
> and read 0 so it's safe to check against it even if DP revision is
> <1.4
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> Signed-off-by: Damian Kos <dkos@cadence.com>
in v4 you received a
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
for this patch. If a patch is largely unchanged from one version to another
please add these previously received tags to the commit message.
This prevents people from reviewing needlessly stuff twice ;-) .
So the above should read
----- 8< -----
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Signed-off-by: Damian Kos <dkos@cadence.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
----- 8< -----
Heiko
next prev parent reply other threads:[~2018-09-25 11:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 9:13 [PATCH v5 0/5] drm: add support for Cadence MHDP DPI/DP bridge Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` [PATCH v5 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` [PATCH v5 2/5] drm/dp: fix link probing for devices supporting DP 1.4+ Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 11:18 ` Heiko Stuebner [this message]
2018-09-25 11:18 ` Heiko Stuebner
2018-09-25 9:13 ` [PATCH v5 3/5] drm/dp: make dp_get_lane_status usable from outside of the core Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-28 7:21 ` Sean Paul
2018-09-28 7:21 ` Sean Paul
2018-09-28 7:21 ` Sean Paul
2018-09-25 9:13 ` [PATCH v5 4/5] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-27 17:38 ` Rob Herring
2018-09-27 17:38 ` Rob Herring
2018-09-27 17:38 ` Rob Herring
2018-09-25 9:13 ` [PATCH v5 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge Damian Kos
2018-09-25 9:13 ` Damian Kos
2018-09-25 9:13 ` Damian Kos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18095829.BFmvNaydv0@phil \
--to=heiko@sntech.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dkos@cadence.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=hjc@rock-chips.com \
--cc=jartur@cadence.com \
--cc=jbergsagel@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ltyrala@cadence.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=pgaj@cadence.com \
--cc=piotrs@cadence.com \
--cc=quentin.schulz@bootlin.com \
--cc=quentin.schulz@free-electrons.com \
--cc=rafalc@cadence.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.