From: Neil Brown <neilb@suse.de>
To: Jeff Layton <jlayton@redhat.com>
Cc: iisaman@citi.umich.edu, nfs@lists.sourceforge.net,
Kevin Coffman <kwc@citi.umich.edu>
Subject: Re: [PATCH] fix regression with rmtab handling in newer nfs-utils code
Date: Tue, 7 Aug 2007 09:55:17 +1000 [thread overview]
Message-ID: <18103.46309.986672.548820@notabene.brown> (raw)
In-Reply-To: message from Jeff Layton on Monday August 6
On Monday August 6, jlayton@redhat.com wrote:
>
> No problem. I just wanted to make sure I wasn't missing something. I
> think this patch against the current git tree should fix it:
Thanks. Applied.
NeilBrown
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
>
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index b686318..15100d4 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -649,8 +649,7 @@ void nfsd_export(FILE *f)
> "Cannot export %s, possibly unsupported filesystem"
> " or fsid= required", path);
> dump_to_cache(f, dom, path, NULL);
> - } else
> - mountlist_add(dom, path);
> + }
> } else {
> dump_to_cache(f, dom, path, NULL);
> }
> @@ -729,7 +728,6 @@ int cache_export_ent(char *domain, struct exportent *exp, char *path)
> "Cannot export %s, possibly unsupported filesystem or"
> " fsid= required", exp->e_path);
> }
> - mountlist_add(domain, exp->e_path);
>
> while (err == 0 && (exp->e_flags & NFSEXP_CROSSMOUNT) && path) {
> /* really an 'if', but we can break out of
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2007-08-06 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 19:55 regression with rmtab handling in newer nfs-utils code Jeff Layton
2007-08-06 22:01 ` Kevin Coffman
2007-08-06 23:18 ` [PATCH] fix " Jeff Layton
2007-08-06 23:55 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18103.46309.986672.548820@notabene.brown \
--to=neilb@suse.de \
--cc=iisaman@citi.umich.edu \
--cc=jlayton@redhat.com \
--cc=kwc@citi.umich.edu \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.