From: Jeff Layton <jlayton@redhat.com>
To: nfs@lists.sourceforge.net
Cc: neilb@suse.de, iisaman@citi.umich.edu, kwc@citi.umich.edu
Subject: regression with rmtab handling in newer nfs-utils code
Date: Mon, 6 Aug 2007 15:55:00 -0400 [thread overview]
Message-ID: <20070806155500.25869737.jlayton@redhat.com> (raw)
I just noticed that there seems to have been a regression with how the
rmtab is handled in the latest nfs-utils code. It seems to have gone
back to adding extra lines to the rmtab that contain the comma-delimited
domain string.
At first glance, it looks like the extra mountlist_add calls that went
in with the patch below are the culprit (though this code seems to have
changed a few times since then). I don't think there's any need to
have cache_export_ent or nfsd_fh call mountlist_add.
Can these calls just be removed, or am I missing something?
commit dbfcba5b03481d49f3e78946fe8fd066e2025545
Author: Kevin Coffman <kwc@citi.umich.edu>
Date: Thu Feb 8 17:27:45 2007 -0500
Remove duplicated code.
Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
Signed-off-by: Kevin Coffman <kwc@citi.umich.edu>
Remove duplicated code.
Signed-off-by: Neil Brown <neilb@suse.de>
--
Jeff Layton <jlayton@redhat.com>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next reply other threads:[~2007-08-06 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 19:55 Jeff Layton [this message]
2007-08-06 22:01 ` regression with rmtab handling in newer nfs-utils code Kevin Coffman
2007-08-06 23:18 ` [PATCH] fix " Jeff Layton
2007-08-06 23:55 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806155500.25869737.jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=iisaman@citi.umich.edu \
--cc=kwc@citi.umich.edu \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.