From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: stable@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,
dev@dpdk.org, hemant.agrawal@nxp.com, bruce.richardson@intel.com
Subject: Re: [dpdk-stable] [PATCH] bus/dpaa: fix compilation issue with meson build
Date: Thu, 21 Jun 2018 10:25:11 +0200 [thread overview]
Message-ID: <1811028.V65RX0Btn7@xps> (raw)
In-Reply-To: <8af66cf6-6059-424d-c6d7-1c2439204b9e@nxp.com>
05/06/2018 08:20, Shreyansh Jain:
> On 6/4/2018 8:22 AM, Jerin Jacob wrote:
> > ccache gcc -Idrivers/drivers@@tmp_rte_pmd_dpaa_sec@sta -Idrivers
> > In file included from ../drivers/bus/dpaa/include/fsl_usd.h:11,
> > from ../drivers/crypto/dpaa_sec/dpaa_sec.c:27:
> > ../drivers/bus/dpaa/include/compat.h:53:
> > error: "__packed" redefined [-Werror]
> > #define __packed __rte_packed
> >
> > In file included from /usr/include/bsd/string.h:39,
> > from ../lib/librte_eal/common/include/rte_string_fns.h:71,
> > from ../drivers/crypto/dpaa_sec/dpaa_sec.c:25:
> > /usr/include/bsd/sys/cdefs.h:120: note: this is the location
> > of the previous definition
> > # define __packed __attribute__((__packed__))
> >
> > Cc: stable@dpdk.org
> > Fixes: 39f373cf015a ("bus/dpaa: add compatibility and helper macros")
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
>
> Thanks Jerin.
> Somehow, this didn't appear on my build environment (maybe because LIB
> BSD is not enabled?). But, the change looks harmless.
>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
I missed this patch and sent a more complete one recently:
https://patches.dpdk.org/patch/41314/
prev parent reply other threads:[~2018-06-21 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 2:52 [PATCH] bus/dpaa: fix compilation issue with meson build Jerin Jacob
2018-06-05 6:20 ` Shreyansh Jain
2018-06-21 8:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1811028.V65RX0Btn7@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.