Re: [PATCH 3/8] arm64: dts: rockchip: Drop regulator-init-microvolt from rk3568-roc-pc

["Heiko Stübner" <heiko@sntech.de>]

Hi Jonas,

Am Dienstag, 1. Oktober 2024, 00:55:42 CEST schrieb Jonas Karlman:
> Hi Heiko,
> 
> On 2024-09-30 23:01, Heiko Stuebner wrote:
> > regulator-init-microvolt is not part of any regulator binding and is
> > only used in the Rockchip vendor kernel. So drop it.
> 
> Mainline U-Boot is also a user of the regulator-init-microvolt prop,
> and use it to help configure an initial voltage on regulators during
> boot.
> 
> Mostly useful for regulators that has different min / max voltage and
> is not enabled by default or set to an unexpected voltage on boot, e.g.
> the typical npu regulator on rk356x defaults to 0.5v, yet needs to be
> around 0.9v during npu probe.
> 
> Maybe a better option would be to try add the init property to the Linux
> dt-bindning?

Looks like that topic comes up regularly, last time in

https://lore.kernel.org/linux-arm-kernel/4519023.cEBGB3zze1@phil/

and that still is true. DT is not a configuration-space, and if needed those
properties should be in the -uboot.dtsi

Heiko


> https://source.denx.de/u-boot/u-boot/-/blob/master/doc/device-tree-bindings/regulator/regulator.txt#L40
> 
> Regards,
> Jonas
> 
> > 
> > Fixes: 007b4bb47f44 ("arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc")
> > Cc: Furkan Kardame <f.kardame@manjaro.org>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> > index e333449ead04..2fa89a0eeafc 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> > @@ -272,7 +272,6 @@ vdd_logic: DCDC_REG1 {
> >  				regulator-name = "vdd_logic";
> >  				regulator-always-on;
> >  				regulator-boot-on;
> > -				regulator-init-microvolt = <900000>;
> >  				regulator-initial-mode = <0x2>;
> >  				regulator-min-microvolt = <500000>;
> >  				regulator-max-microvolt = <1350000>;
> > @@ -285,7 +284,6 @@ regulator-state-mem {
> >  
> >  			vdd_gpu: DCDC_REG2 {
> >  				regulator-name = "vdd_gpu";
> > -				regulator-init-microvolt = <900000>;
> >  				regulator-initial-mode = <0x2>;
> >  				regulator-min-microvolt = <500000>;
> >  				regulator-max-microvolt = <1350000>;
> > @@ -309,7 +307,6 @@ regulator-state-mem {
> >  
> >  			vdd_npu: DCDC_REG4 {
> >  				regulator-name = "vdd_npu";
> > -				regulator-init-microvolt = <900000>;
> >  				regulator-initial-mode = <0x2>;
> >  				regulator-min-microvolt = <500000>;
> >  				regulator-max-microvolt = <1350000>;
> 
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip