From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/6] ARM: dts: rockchip: use the same pmu node name as before
Date: Sat, 11 Oct 2014 19:43:08 +0200 [thread overview]
Message-ID: <1817294.fFByve75fK@phil> (raw)
In-Reply-To: <1412976370-14468-3-git-send-email-kever.yang@rock-chips.com>
Am Freitag, 10. Oktober 2014, 14:26:06 schrieb Kever Yang:
> We use the "rockchip,rk3066-pmu" for rk3288 instead of creat
> a new one.
No, it should stay keep the rk3288-pmu compatible. While the 4 powerdomains
for the cores are similar, the pmu in general is very much specific to the
rk3288.
Also, this renaming of the pmu compatible only is a workaround for the
underlying problem, that your tree is probably missing the early syscon
support and there falling back to mapping the node directly.
If you apply the patch
[PATCH v7] mfd: syscon: Decouple syscon interface from platform devices
to your tree, it will work as expected by really using the pmu reference from
patch3 - it did for me - making this patch unnecessary.
Heiko
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v3:
> - add this patch in version 3
>
> Changes in v2: None
>
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..06f39be 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -440,7 +440,7 @@
> };
>
> pmu: power-management at ff730000 {
> - compatible = "rockchip,rk3288-pmu", "syscon";
> + compatible = "rockchip,rk3066-pmu", "syscon";
> reg = <0xff730000 0x100>;
> };
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: dianders@chromium.org, sonnyrao@chromium.org,
addy.ke@rock-chips.com, cf@rock-chips.com, xjq@rock-chips.com,
hj@rock-chips.com, huangtao@rock-chips.com,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/6] ARM: dts: rockchip: use the same pmu node name as before
Date: Sat, 11 Oct 2014 19:43:08 +0200 [thread overview]
Message-ID: <1817294.fFByve75fK@phil> (raw)
In-Reply-To: <1412976370-14468-3-git-send-email-kever.yang@rock-chips.com>
Am Freitag, 10. Oktober 2014, 14:26:06 schrieb Kever Yang:
> We use the "rockchip,rk3066-pmu" for rk3288 instead of creat
> a new one.
No, it should stay keep the rk3288-pmu compatible. While the 4 powerdomains
for the cores are similar, the pmu in general is very much specific to the
rk3288.
Also, this renaming of the pmu compatible only is a workaround for the
underlying problem, that your tree is probably missing the early syscon
support and there falling back to mapping the node directly.
If you apply the patch
[PATCH v7] mfd: syscon: Decouple syscon interface from platform devices
to your tree, it will work as expected by really using the pmu reference from
patch3 - it did for me - making this patch unnecessary.
Heiko
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v3:
> - add this patch in version 3
>
> Changes in v2: None
>
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..06f39be 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -440,7 +440,7 @@
> };
>
> pmu: power-management@ff730000 {
> - compatible = "rockchip,rk3288-pmu", "syscon";
> + compatible = "rockchip,rk3066-pmu", "syscon";
> reg = <0xff730000 0x100>;
> };
next prev parent reply other threads:[~2014-10-11 17:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 21:26 [PATCH v3 0/6] add basic rk3288 smp support Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-10 21:26 ` [PATCH v3 1/6] ARM: rockchip: convert to regmap and use pmu syscon if available Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-11 17:42 ` Heiko Stübner
2014-10-11 17:42 ` Heiko Stübner
2014-10-10 21:26 ` [PATCH v3 2/6] ARM: dts: rockchip: use the same pmu node name as before Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-11 17:43 ` Heiko Stübner [this message]
2014-10-11 17:43 ` Heiko Stübner
2014-10-10 21:26 ` [PATCH v3 3/6] ARM: rockchip: add option to access the pmu via a phandle in smp_operations Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-11 17:45 ` Heiko Stübner
2014-10-11 17:45 ` Heiko Stübner
2014-10-10 21:26 ` [PATCH v3 4/6] ARM: dts: rockchip: add pmu references to cpus nodes Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-11 17:47 ` Heiko Stübner
2014-10-11 17:47 ` Heiko Stübner
2014-10-11 17:47 ` Heiko Stübner
2014-10-10 21:26 ` [PATCH v3 5/6] ARM: rockchip: add basic smp support for rk3288 Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-11 17:55 ` Heiko Stübner
2014-10-11 17:55 ` Heiko Stübner
2014-10-10 21:26 ` [PATCH v3 6/6] ARM: dts: rockchip: add intmem node for rk3288 smp support Kever Yang
2014-10-10 21:26 ` Kever Yang
2014-10-11 18:01 ` Heiko Stübner
2014-10-11 18:01 ` Heiko Stübner
2014-10-11 18:04 ` [PATCH v3 0/6] add basic " Heiko Stübner
2014-10-11 18:04 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1817294.fFByve75fK@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.