All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>, Chukun Pan <amadeus@jmu.edu.cn>
Cc: Samuel Holland <samuel@sholland.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	Chukun Pan <amadeus@jmu.edu.cn>
Subject: Re: Re: [PATCH] arm64: dts: allwinner: define USB3 Ethernet on NanoPi R1S H5
Date: Tue, 03 May 2022 22:00:44 +0200	[thread overview]
Message-ID: <1818121.CQOukoFCf9@kista> (raw)
In-Reply-To: <4393725.LvFx2qVVIh@kista>

Dne torek, 03. maj 2022 ob 19:54:34 CEST je Jernej Škrabec napisal(a):
> Dne ponedeljek, 02. maj 2022 ob 16:40:09 CEST je Chukun Pan napisal(a):
> > The NanoPi R1S H5 has a Realtek RTL8153B USB 3.0 Ethernet chip
> > connected to the USB 2.0 port of the Allwinner H5 SoC.
> > 
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/
> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> > index 55b369534a08..dd655a491549 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> > @@ -21,7 +21,8 @@ / {
> >  
> >  	aliases {
> >  		ethernet0 = &emac;
> > -		ethernet1 = &rtl8189etv;
> > +		ethernet1 = &rtl8153;
> > +		ethernet2 = &rtl8189etv;

Additionally, it's not a good idea to change order of ethernet nodes. It can 
affect mac address assigning procedure in bootloader.

Best regards,
Jernej

> >  		serial0 = &uart0;
> >  	};
> >  
> > @@ -116,6 +117,11 @@ &cpu0 {
> >  
> >  &ehci1 {
> >  	status = "okay";
> 
> You need to add #address-cells and #size-cells properties, otherwise "make 
> dtbs_check W=1" generates warnings.
> 
> Best regards,
> Jernej
> 
> > +
> > +	rtl8153: device@1 {
> > +		compatible = "usbbda,8153";
> > +		reg = <1>;
> > +	};
> >  };
> >  
> >  &ehci2 {
> > -- 
> > 2.25.1
> > 
> > 
> 
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>, Chukun Pan <amadeus@jmu.edu.cn>
Cc: Samuel Holland <samuel@sholland.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	Chukun Pan <amadeus@jmu.edu.cn>
Subject: Re: Re: [PATCH] arm64: dts: allwinner: define USB3 Ethernet on NanoPi R1S H5
Date: Tue, 03 May 2022 22:00:44 +0200	[thread overview]
Message-ID: <1818121.CQOukoFCf9@kista> (raw)
In-Reply-To: <4393725.LvFx2qVVIh@kista>

Dne torek, 03. maj 2022 ob 19:54:34 CEST je Jernej Škrabec napisal(a):
> Dne ponedeljek, 02. maj 2022 ob 16:40:09 CEST je Chukun Pan napisal(a):
> > The NanoPi R1S H5 has a Realtek RTL8153B USB 3.0 Ethernet chip
> > connected to the USB 2.0 port of the Allwinner H5 SoC.
> > 
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/
> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> > index 55b369534a08..dd655a491549 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> > @@ -21,7 +21,8 @@ / {
> >  
> >  	aliases {
> >  		ethernet0 = &emac;
> > -		ethernet1 = &rtl8189etv;
> > +		ethernet1 = &rtl8153;
> > +		ethernet2 = &rtl8189etv;

Additionally, it's not a good idea to change order of ethernet nodes. It can 
affect mac address assigning procedure in bootloader.

Best regards,
Jernej

> >  		serial0 = &uart0;
> >  	};
> >  
> > @@ -116,6 +117,11 @@ &cpu0 {
> >  
> >  &ehci1 {
> >  	status = "okay";
> 
> You need to add #address-cells and #size-cells properties, otherwise "make 
> dtbs_check W=1" generates warnings.
> 
> Best regards,
> Jernej
> 
> > +
> > +	rtl8153: device@1 {
> > +		compatible = "usbbda,8153";
> > +		reg = <1>;
> > +	};
> >  };
> >  
> >  &ehci2 {
> > -- 
> > 2.25.1
> > 
> > 
> 
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-03 20:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 14:40 [PATCH] arm64: dts: allwinner: define USB3 Ethernet on NanoPi R1S H5 Chukun Pan
2022-05-02 14:40 ` Chukun Pan
2022-05-03 17:54 ` Jernej Škrabec
2022-05-03 17:54   ` Jernej Škrabec
2022-05-03 20:00   ` Jernej Škrabec [this message]
2022-05-03 20:00     ` Jernej Škrabec
2022-05-08 15:25   ` Chukun Pan
2022-05-08 15:25     ` Chukun Pan
2022-05-09  8:52     ` Andre Przywara
2022-05-09  8:52       ` Andre Przywara
2022-05-09 15:00     ` Chukun Pan
2022-05-09 15:00       ` Chukun Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1818121.CQOukoFCf9@kista \
    --to=jernej.skrabec@gmail.com \
    --cc=amadeus@jmu.edu.cn \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.