From: Tomasz Figa <tomasz.figa@gmail.com>
To: Vikas Sajjan <vikas.sajjan@linaro.org>
Cc: mturquette@linaro.org, linux-samsung-soc@vger.kernel.org,
kgene.kim@samsung.com, t.figa@samsung.com, dianders@chromium.org,
patches@linaro.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 2/2] clk: samsung: Add APLL, KPLL, EPLL and VPLL freq table for exynos5420 SoC
Date: Wed, 28 Aug 2013 10:18:32 +0200 [thread overview]
Message-ID: <1819543.NdlB5vViSf@flatron> (raw)
In-Reply-To: <1376301734-21847-3-git-send-email-vikas.sajjan@linaro.org>
Hi Vikas,
On Monday 12 of August 2013 15:32:14 Vikas Sajjan wrote:
> Adds APLL, KPLL, EPLL and VPLL freq table for exynos5420 SoC.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> drivers/clk/samsung/clk-exynos5420.c | 81
> ++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-exynos5420.c
> b/drivers/clk/samsung/clk-exynos5420.c index e035fd0..42cea7e 100644
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -757,10 +757,81 @@ static struct of_device_id ext_clk_match[]
> __initdata = { { },
> };
>
> +static struct samsung_pll_rate_table apll_24mhz_tbl[] __initdata = {
> + /* sorted in descending order */
> + /* PLL_35XX_RATE(rate, m, p, s) */
> + PLL_35XX_RATE(2000000000, 250, 3, 0),
> + PLL_35XX_RATE(1900000000, 475, 6, 0),
> + PLL_35XX_RATE(1800000000, 225, 3, 0),
> + PLL_35XX_RATE(1700000000, 425, 6, 0),
> + PLL_35XX_RATE(1600000000, 200, 3, 0),
> + PLL_35XX_RATE(1500000000, 250, 4, 0),
> + PLL_35XX_RATE(1400000000, 175, 3, 0),
> + PLL_35XX_RATE(1300000000, 325, 6, 0),
> + PLL_35XX_RATE(1200000000, 200, 2, 1),
> + PLL_35XX_RATE(1100000000, 275, 3, 1),
> + PLL_35XX_RATE(1000000000, 250, 3, 1),
> + PLL_35XX_RATE(900000000, 150, 2, 1),
> + PLL_35XX_RATE(800000000, 200, 3, 1),
> + PLL_35XX_RATE(700000000, 175, 3, 1),
> + PLL_35XX_RATE(600000000, 200, 2, 2),
> + PLL_35XX_RATE(500000000, 250, 3, 2),
> + PLL_35XX_RATE(400000000, 200, 3, 2),
> + PLL_35XX_RATE(300000000, 400, 4, 3),
> + PLL_35XX_RATE(200000000, 200, 3, 3),
> + { },
> +};
> +
> +static struct samsung_pll_rate_table kpll_24mhz_tbl[] __initdata = {
> + /* sorted in descending order */
> + /* PLL_35XX_RATE(rate, m, p, s) */
> + PLL_35XX_RATE(1300000000, 325, 6, 0),
> + PLL_35XX_RATE(1200000000, 200, 2, 1),
> + PLL_35XX_RATE(1100000000, 275, 3, 1),
> + PLL_35XX_RATE(1000000000, 250, 3, 1),
> + PLL_35XX_RATE(900000000, 150, 2, 1),
> + PLL_35XX_RATE(800000000, 200, 3, 1),
> + PLL_35XX_RATE(700000000, 175, 3, 1),
> + PLL_35XX_RATE(600000000, 200, 2, 2),
> + PLL_35XX_RATE(500000000, 250, 3, 2),
> + PLL_35XX_RATE(400000000, 200, 3, 2),
> + PLL_35XX_RATE(300000000, 400, 4, 3),
> + PLL_35XX_RATE(200000000, 200, 3, 3),
> + { },
> +};
> +
> +static struct samsung_pll_rate_table epll_24mhz_tbl[] __initdata = {
> + /* sorted in descending order */
> + /* PLL_36XX_RATE(rate, m, p, s, k) */
> + PLL_36XX_RATE(192000000, 64, 2, 2, 0),
> + PLL_36XX_RATE(180633600, 45, 3, 1, 10381),
This one is in fact 180633605 Hz.
> + PLL_36XX_RATE(180000000, 45, 3, 1, 0),
> + PLL_36XX_RATE(73728000, 98, 2, 4, 19923),
> + PLL_36XX_RATE(67737600, 90, 2, 4, 20762),
67737602 Hz
> + PLL_36XX_RATE(49152000, 98, 3, 4, 19923),
> + PLL_36XX_RATE(45158400, 90, 3, 4, 20762),
45158401 Hz
> + PLL_36XX_RATE(32768000, 131, 3, 5, 4719),
32768001 Hz
> + { },
> +};
> +
> +static struct samsung_pll_rate_table vpll_24mhz_tbl[] __initdata = {
> + /* sorted in descending order */
> + /* PLL_35XX_RATE(rate, m, p, s) */
> + PLL_35XX_RATE(533000000, 533, 6, 2),
> + PLL_35XX_RATE(480000000, 160, 2, 2),
> + PLL_35XX_RATE(420000000, 140, 2, 2),
> + PLL_35XX_RATE(350000000, 175, 3, 2),
> + PLL_35XX_RATE(266000000, 266, 3, 3),
> + PLL_35XX_RATE(177000000, 118, 2, 3),
> + PLL_35XX_RATE(100000000, 200, 3, 4),
> + { },
> +};
> +
> /* register exynos5420 clocks */
> static void __init exynos5420_clk_init(struct device_node *np)
> {
> void __iomem *reg_base;
> + unsigned long fin_pll_rate;
This variable seems to be unnecessary. See below.
>
> if (np) {
> reg_base = of_iomap(np, 0);
> @@ -776,6 +847,16 @@ static void __init exynos5420_clk_init(struct
> device_node *np)
> samsung_clk_of_register_fixed_ext(exynos5420_fixed_rate_ext_clks,
> ARRAY_SIZE(exynos5420_fixed_rate_ext_clks),
> ext_clk_match);
> +
> + fin_pll_rate = _get_rate("fin_pll");
> +
> + if (fin_pll_rate == 24 * MHZ) {
You can simplify this to
if (_get_rate("fin_pll") == 24 * MHZ) {
Best regards,
Tomasz
next prev parent reply other threads:[~2013-08-28 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 10:02 [PATCH 0/2] Add GPLL, APLL, KPLL, EPLL and VPLL freq table for exynos5420 and exynos5250 Vikas Sajjan
2013-08-12 10:02 ` [PATCH 1/2] clk: samsung: Add GPLL freq table for exynos5250 SoC Vikas Sajjan
2013-08-28 8:06 ` Tomasz Figa
2013-08-12 10:02 ` [PATCH 2/2] clk: samsung: Add APLL, KPLL, EPLL and VPLL freq table for exynos5420 SoC Vikas Sajjan
2013-08-28 8:18 ` Tomasz Figa [this message]
2013-08-14 5:06 ` [PATCH 0/2] Add GPLL, APLL, KPLL, EPLL and VPLL freq table for exynos5420 and exynos5250 Vikas Sajjan
2013-08-14 15:37 ` Tomasz Figa
2013-08-22 7:00 ` Vikas Sajjan
2013-08-28 5:15 ` Vikas Sajjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1819543.NdlB5vViSf@flatron \
--to=tomasz.figa@gmail.com \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=patches@linaro.org \
--cc=t.figa@samsung.com \
--cc=vikas.sajjan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.