Re: [PATCH] riscv: dts: starfive: jh7110-common: keep the status power LED on

From: E Shattow <e@freeshell.de>
To: Conor Dooley <conor@kernel.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Owen O'Hehir <oo.hehir@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: keep the status power LED on
Date: Fri, 6 Nov 2026 11:06:22 -0800	[thread overview]
Message-ID: <181fdcd8-80ff-4486-ab16-9cbce16b0a29@freeshell.de> (raw)
In-Reply-To: <179399127414.1902073.729566010968054971.b4-ty@microchip.com>

Hi Conor,

On 11/6/26 10:54, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> On Fri, 06 Nov 2026 18:40:55 +0000, Owen O'Hehir wrote:
>> The firmware turns the status power LED on, but the node has no
>> default-state, so the LED switches off when leds-gpio probes and the
>> board looks powered down.
>>
>> Default the LED to on.
>>
>> Tested on a VisionFive 2 v1.3B.
>>
>> [...]
> 
> Applied to riscv-dt-fixes, thanks!
> 
> [1/1] riscv: dts: starfive: jh7110-common: keep the status power LED on
>       https://git.kernel.org/conor/c/68dbe2550bd4
> 
> Thanks,
> Conor.

I replied this a moment earlier:
https://lore.kernel.org/lkml/179fe9e8-322b-4745-8734-d5de5f1e8487@freeshell.de/

This disagrees with VisionFive 2 Lite schematic; if when this node is
consumed by a bootloader it will be evident we are not describing the
hardware correctly, no?

If you want the light on and it wasn't on at reset or due to boot ROM,
then that is userland stuff and not hardware description... but that is
your decision to make as maintainer.

-E

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv