From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v9 2/3] Move common functions in eal_timer.c
Date: Mon, 27 Jul 2015 01:32:18 +0200 [thread overview]
Message-ID: <18210927.c72O7E0spP@xps13> (raw)
In-Reply-To: <1437852990-6096-2-git-send-email-rkerur@gmail.com>
2015-07-25 12:36, Ravi Kerur:
> +static void
> +set_tsc_freq_fallback(void)
> +{
> + RTE_LOG(WARNING, EAL, "WARNING: clock_gettime cannot use "
> + "CLOCK_MONOTONIC_RAW and HPET is not available"
Not generic enough for BSD.
We can say "TSC frequency estimated roughly"
> + " - clock timings may be less accurate.\n");
> + /* assume that the sleep(1) will sleep for 1 second */
[...]
> +/**
> + * This function sets TSC frequency from sysctl
It is not the style of the file to start with "This function..."
> + * for BSD and from clock for Linux.
> + * Is a wrapper function for BSD which will
> + * internally call set_tsc_freq_from_sysctl.
This sentence is an implementation detail.
next prev parent reply other threads:[~2015-07-26 23:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 19:34 [PATCH v9 0/3] Move EAL common functions Ravi Kerur
2015-07-25 19:36 ` [PATCH v9 1/3] Move common functions in eal_lcore.c Ravi Kerur
2015-07-25 19:36 ` [PATCH v9 2/3] Move common functions in eal_timer.c Ravi Kerur
2015-07-26 23:32 ` Thomas Monjalon [this message]
2015-07-26 23:40 ` Thomas Monjalon
2015-07-25 19:36 ` [PATCH v9 3/3] Move common functions in eal_memory.c Ravi Kerur
2015-07-27 0:35 ` Thomas Monjalon
2015-07-25 19:36 ` [PATCH v9 0/3] Move EAL common functions Ravi Kerur
2015-07-27 0:56 ` [PATCH v10 0/3] deduplicate " Thomas Monjalon
2015-07-27 0:56 ` [PATCH v10 1/3] eal: deduplicate lcore initialization Thomas Monjalon
2015-07-27 0:56 ` [PATCH v10 2/3] eal: deduplicate timer functions Thomas Monjalon
2015-07-27 0:56 ` [PATCH v10 3/3] eal: deduplicate memory initialization Thomas Monjalon
2015-07-27 0:59 ` [PATCH v10 0/3] deduplicate EAL common functions Thomas Monjalon
2015-07-30 8:12 ` Olivier MATZ
2015-07-30 12:15 ` Ravi Kerur
2015-07-30 13:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18210927.c72O7E0spP@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.