From: Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, rkerur@gmail.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v10 0/3] deduplicate EAL common functions
Date: Thu, 30 Jul 2015 10:12:31 +0200 [thread overview]
Message-ID: <55B9DC6F.7040506@6wind.com> (raw)
In-Reply-To: <3055506.vZLM2IGfDr@xps13>
Hi Thomas & Ravi,
On 07/27/2015 02:59 AM, Thomas Monjalon wrote:
> 2015-07-27 02:56, Thomas Monjalon:
>> v9 was a subset of previous deduplications by Ravi Kerur.
>> This v10 address the comments I've done on v9.
>>
>> Ravi Kerur (3):
>> eal: deduplicate lcore initialization
>> eal: deduplicate timer functions
>> eal: deduplicate memory initialization
>
> Applied shortly to integrate this old pending cleanup in RC2.
>
When I try to compile the dpdk for x86_x32-native-linuxapp-gcc , I
get the following compilation error:
CC eal_common_timer.o
In file included from /usr/include/sys/sysctl.h:63:0,
from
/home/matz/dpdk-pkg-cron/dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
/usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is
unsupported in x32 kernel"
# error "sysctl system call is unsupported in x32 kernel"
^
Removing the "#include <sys/sysctl.h>" line fixes the issue without
impacting the compilation. I think this include is not needed and
could be removed.
I can provide a patch if it's ok for you.
Regards,
Olivier
next prev parent reply other threads:[~2015-07-30 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 19:34 [PATCH v9 0/3] Move EAL common functions Ravi Kerur
2015-07-25 19:36 ` [PATCH v9 1/3] Move common functions in eal_lcore.c Ravi Kerur
2015-07-25 19:36 ` [PATCH v9 2/3] Move common functions in eal_timer.c Ravi Kerur
2015-07-26 23:32 ` Thomas Monjalon
2015-07-26 23:40 ` Thomas Monjalon
2015-07-25 19:36 ` [PATCH v9 3/3] Move common functions in eal_memory.c Ravi Kerur
2015-07-27 0:35 ` Thomas Monjalon
2015-07-25 19:36 ` [PATCH v9 0/3] Move EAL common functions Ravi Kerur
2015-07-27 0:56 ` [PATCH v10 0/3] deduplicate " Thomas Monjalon
2015-07-27 0:56 ` [PATCH v10 1/3] eal: deduplicate lcore initialization Thomas Monjalon
2015-07-27 0:56 ` [PATCH v10 2/3] eal: deduplicate timer functions Thomas Monjalon
2015-07-27 0:56 ` [PATCH v10 3/3] eal: deduplicate memory initialization Thomas Monjalon
2015-07-27 0:59 ` [PATCH v10 0/3] deduplicate EAL common functions Thomas Monjalon
2015-07-30 8:12 ` Olivier MATZ [this message]
2015-07-30 12:15 ` Ravi Kerur
2015-07-30 13:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B9DC6F.7040506@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.