All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Anderson <anderson@redhat.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: olaf@aepfle.de, xen-devel@lists.xensource.com,
	konrad wilk <konrad.wilk@oracle.com>,
	andrew cooper3 <andrew.cooper3@citrix.com>,
	ptesarik@suse.cz, jbeulich@suse.com, kexec@lists.infradead.org,
	crash-utility@redhat.com
Subject: Re: [PATCH v2 0/6] crash: Bundle of fixes for Xen
Date: Mon, 13 Aug 2012 15:16:53 -0400 (EDT)	[thread overview]
Message-ID: <1827880283.12350529.1344885413402.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120813073754.GA2482@host-192-168-1-59.local.net-space.pl>



----- Original Message -----
> On Fri, Aug 10, 2012 at 03:11:57PM -0400, Dave Anderson wrote:
> >
> >
> > ----- Original Message -----
> > > Hi,
> > >
> > > It looks that Xen support for crash have not been maintained
> > > since 2009. I am trying to fix this. Here it is bundle of fixes:
> > >   - xen: Always calculate max_cpus value,
> > >   - xen: Read only crash notes for onlined CPUs,
> > >   - x86/xen: Read variables from dynamically allocated per_cpu
> > >   data,
> > >   - xen: Get idle data from alternative source,
> > >   - xen: Read data correctly from dynamically allocated console
> > >   ring, too
> > >     (fixed in this release),
> > >   - xen: Add support for 3 level P2M tree (new patch in this
> > >   release).
> > >
> > > Daniel
> >
> > Hi Daniel,
> >
> > The original 5 updates specific to the Xen hypervisor look OK,
> > but new patch 6/6 is going to take some studying/testing to
> > alleviate my backwards-compatibility worries.  Can I ask whether
> > you fully tested it with older 2-level P2M tree kernels?
> 
> As you asked me earlier I have tested all patches on Xen 3.1 and 4.1,
> Linux Kernel Ver. 2.6.18 (P2M array), 2.6.36 (2 level P2M tree)
> and 2.6.39 (3 level P2M tree). Additionaly, there were some internal
> tests done by others in my company.
> 
> Daniel

OK good.  It tests OK on a few older pvops kernels that I have on hand.

The only thing I've changed is to handle compiler warnings in x86_64.c and 
x86.c by initializing p2m_top to NULL in x86_64_pvops_xendump_p2m_l3_create()
and x86_pvops_xendump_p2m_l3_create().  I also used GETBUF() in those two
functions to avoid having to add the malloc-failure line.

Queued for crash-6.0.9.

Thanks,
  Dave
  

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Dave Anderson <anderson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: olaf-QOLJcTWqO2uzQB+pC5nmwQ@public.gmane.org,
	xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org,
	konrad wilk <konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	andrew cooper3
	<andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
	ptesarik-AlSwsSmVLrQ@public.gmane.org,
	jbeulich-IBi9RG/b67k@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	crash-utility-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2 0/6] crash: Bundle of fixes for Xen
Date: Mon, 13 Aug 2012 15:16:53 -0400 (EDT)	[thread overview]
Message-ID: <1827880283.12350529.1344885413402.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120813073754.GA2482-UojuW/CpjwpdUOLzJiIvSsFoITBeLw/klGfBN0aaEZ+lPcVs/6D9LQ@public.gmane.org>



----- Original Message -----
> On Fri, Aug 10, 2012 at 03:11:57PM -0400, Dave Anderson wrote:
> >
> >
> > ----- Original Message -----
> > > Hi,
> > >
> > > It looks that Xen support for crash have not been maintained
> > > since 2009. I am trying to fix this. Here it is bundle of fixes:
> > >   - xen: Always calculate max_cpus value,
> > >   - xen: Read only crash notes for onlined CPUs,
> > >   - x86/xen: Read variables from dynamically allocated per_cpu
> > >   data,
> > >   - xen: Get idle data from alternative source,
> > >   - xen: Read data correctly from dynamically allocated console
> > >   ring, too
> > >     (fixed in this release),
> > >   - xen: Add support for 3 level P2M tree (new patch in this
> > >   release).
> > >
> > > Daniel
> >
> > Hi Daniel,
> >
> > The original 5 updates specific to the Xen hypervisor look OK,
> > but new patch 6/6 is going to take some studying/testing to
> > alleviate my backwards-compatibility worries.  Can I ask whether
> > you fully tested it with older 2-level P2M tree kernels?
> 
> As you asked me earlier I have tested all patches on Xen 3.1 and 4.1,
> Linux Kernel Ver. 2.6.18 (P2M array), 2.6.36 (2 level P2M tree)
> and 2.6.39 (3 level P2M tree). Additionaly, there were some internal
> tests done by others in my company.
> 
> Daniel

OK good.  It tests OK on a few older pvops kernels that I have on hand.

The only thing I've changed is to handle compiler warnings in x86_64.c and 
x86.c by initializing p2m_top to NULL in x86_64_pvops_xendump_p2m_l3_create()
and x86_pvops_xendump_p2m_l3_create().  I also used GETBUF() in those two
functions to avoid having to add the malloc-failure line.

Queued for crash-6.0.9.

Thanks,
  Dave

  reply	other threads:[~2012-08-13 19:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 13:23 [PATCH v2 0/6] crash: Bundle of fixes for Xen Daniel Kiper
2012-08-10 13:23 ` Daniel Kiper
2012-08-10 19:11 ` Dave Anderson
2012-08-10 19:11   ` Dave Anderson
2012-08-13  7:37   ` Daniel Kiper
2012-08-13  7:37     ` Daniel Kiper
2012-08-13 19:16     ` Dave Anderson [this message]
2012-08-13 19:16       ` Dave Anderson
2012-08-14  6:14       ` Daniel Kiper
2012-08-14  6:14         ` Daniel Kiper
2012-08-14 14:04         ` Dave Anderson
2012-08-14 14:04           ` Dave Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1827880283.12350529.1344885413402.JavaMail.root@redhat.com \
    --to=anderson@redhat.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=crash-utility@redhat.com \
    --cc=daniel.kiper@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=kexec@lists.infradead.org \
    --cc=konrad.wilk@oracle.com \
    --cc=olaf@aepfle.de \
    --cc=ptesarik@suse.cz \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.