All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Tokarev <annulen@yandex.ru>
To: Brent Taylor <motobud@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: lz4hc compression in UBIFS?
Date: Mon, 21 Oct 2013 19:59:20 +0400	[thread overview]
Message-ID: <183031382371160@web6m.yandex.ru> (raw)
In-Reply-To: <CAP+RiCAVuUEfyjg02+ZjeFXgUuaRW+fuMB490Ce2Hq_4qHBL=A@mail.gmail.com>



04.10.2013, 07:09, "Brent Taylor" <motobud@gmail.com>:
> Here is a patch based on linux-3.12-rc3.  I haven't performed any
> performance testing UBIFS using lz4hc, but I can mount UBIFS volumes
> and haven't seen any problems yet.  The only think I know that isn't
> correct about the patch is the description for the Kconfig element for
> select lz4hc as a compression option.  I only copied the description
> from the lzo description.

Hi Brent,

I'm testing your patch on my SH4 device. When I create new partition
with lz4hc compressor, it works fine: I can copy file into it, and
md5sums of original and copy match. However, after reboot I cannot
read the file anymore:

UBIFS error (pid 1101): ubifs_decompress: cannot decompress 934 bytes, compressor lz4hc, error -22
UBIFS error (pid 1101): read_block: bad data node (block 1, inode 65)
UBIFS error (pid 1101): do_readpage: cannot read page 1 of inode 65, error -22

The same error appears if I use lz4hc-compressed ubifs image to flash rootfs
(using patched mkfs.ubifs).

Decompression error occurs in lz4_uncompress() function (lib/lz4/lz4_decompress.c),
on the line 101:

/* Error: offset create reference outside destination buffer */
if (unlikely(ref < (BYTE *const) dest))
    goto _output_error;

Brent: are you able to read data from lz4hc volume on your device?
Anyone: any ideas what may happen here?

-- 
Regards,
Konstantin

  parent reply	other threads:[~2013-10-21 16:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 12:16 lz4hc compression in UBIFS? Konstantin Tokarev
2013-10-04  3:09 ` Brent Taylor
2013-10-04  7:44   ` Artem Bityutskiy
2013-10-04  8:06   ` Konstantin Tokarev
2013-10-21 15:59   ` Konstantin Tokarev [this message]
2013-10-22  3:43     ` Brent Taylor
2013-10-22 10:10       ` Konstantin Tokarev
2013-10-23  5:26         ` Brent Taylor
2013-10-23  5:26           ` Brent Taylor
2013-10-23  7:40           ` Konstantin Tokarev
2013-10-23  7:40             ` Konstantin Tokarev
2013-10-23 12:49             ` Brent Taylor
2013-10-23 12:49               ` Brent Taylor
2013-10-23 13:39               ` Konstantin Tokarev
2013-10-23 13:39                 ` Konstantin Tokarev
2013-10-23 18:19   ` Yann Collet
2013-10-24 14:12     ` Konstantin Tokarev
2013-10-24 15:15       ` Konstantin Tokarev
2013-10-28 16:22         ` Konstantin Tokarev
2013-10-28 16:45           ` Florian Fainelli
2013-10-28 16:45             ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=183031382371160@web6m.yandex.ru \
    --to=annulen@yandex.ru \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=motobud@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.