From: Konstantin Tokarev <annulen@yandex.ru>
To: Yann Collet <yann.collet.73@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: lz4hc compression in UBIFS?
Date: Thu, 24 Oct 2013 18:12:22 +0400 [thread overview]
Message-ID: <237221382623942@web21m.yandex.ru> (raw)
In-Reply-To: <loom.20131023T201657-894@post.gmane.org>
23.10.2013, 22:26, "Yann Collet" <yann.collet.73@gmail.com>:
> UBIFS error (pid 4288): ubifs_decompress: cannot decompress 12 bytes,
> (...)
> data size 12
> data:
> 00000000: 1f 00 01 00 ff e8 50 00 00 00 00 00
>
> The compressed format is correct.
> It describes a flow of 00, of size ~500.
>
> So the problem seems more likely on the decompression side.
>
> Are you sure you are providing "12" as the "input size" parameter ? and that
> the "maximum output size" parameter is correctly provided ? (i.e. >= to
> original data size)
>
Decompression code in kernel[1] is heavily modified. In particular, lz4_uncompress
function (used in this case) does not have input size parameter at all,
while it's present in lz4_uncompress_unknownoutputsize.
[1] lib/lz4/lz4_decompress.c
--
Regards,
Konstantin
next prev parent reply other threads:[~2013-10-24 14:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 12:16 lz4hc compression in UBIFS? Konstantin Tokarev
2013-10-04 3:09 ` Brent Taylor
2013-10-04 7:44 ` Artem Bityutskiy
2013-10-04 8:06 ` Konstantin Tokarev
2013-10-21 15:59 ` Konstantin Tokarev
2013-10-22 3:43 ` Brent Taylor
2013-10-22 10:10 ` Konstantin Tokarev
2013-10-23 5:26 ` Brent Taylor
2013-10-23 5:26 ` Brent Taylor
2013-10-23 7:40 ` Konstantin Tokarev
2013-10-23 7:40 ` Konstantin Tokarev
2013-10-23 12:49 ` Brent Taylor
2013-10-23 12:49 ` Brent Taylor
2013-10-23 13:39 ` Konstantin Tokarev
2013-10-23 13:39 ` Konstantin Tokarev
2013-10-23 18:19 ` Yann Collet
2013-10-24 14:12 ` Konstantin Tokarev [this message]
2013-10-24 15:15 ` Konstantin Tokarev
2013-10-28 16:22 ` Konstantin Tokarev
2013-10-28 16:45 ` Florian Fainelli
2013-10-28 16:45 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237221382623942@web21m.yandex.ru \
--to=annulen@yandex.ru \
--cc=linux-mtd@lists.infradead.org \
--cc=yann.collet.73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.