From: Martin Steigerwald <martin@lichtvoll.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Linux-scsi@vger.kernel.org,
John Garry <john.garry@huawei.com>,
linux-nvme@lists.infradead.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
lsf-pc@lists.linux-foundation.org
Subject: Re: [Lsf-pc] [LSF/MM TOPIC] Two blk-mq related topics
Date: Tue, 30 Jan 2018 09:33:18 +0100 [thread overview]
Message-ID: <1831727.Vh41F2Boqi@merkaba> (raw)
In-Reply-To: <20180130012408.GD17176@ming.t460p>
TWluZyBMZWkgLSAzMC4wMS4xOCwgMDI6MjQ6Cj4gPiA+IFNDU0lfTVEgaXMgZW5hYmxlZCBvbiBW
My4xNyBmaXJzdGx5LCBidXQgZGlzYWJsZWQgYXQgZGVmYXVsdC4gSW4KPiA+ID4gVjQuMTMtcmMx
LCBpdCBpcyBlbmFibGVkIGF0IGRlZmF1bHQsIGJ1dCBsYXRlciB0aGUgcGF0Y2ggaXMgcmV2ZXJ0
ZWQKPiA+ID4gaW4gVjQuMTMtcmM3LCBhbmQgYmVjb21lcyBkaXNhYmxlZCBhdCBkZWZhdWx0IHRv
by4KPiA+ID4gCj4gPiA+IE5vdyBib3RoIHRoZSBvcmlnaW5hbCByZXBvcnRlZCBQTSBpc3N1ZShh
Y3R1YWxseSBTQ1NJIHF1aWVzY2UpIGFuZAo+ID4gPiB0aGUgc2VxdWVudGlhbCBJTyBwZXJmb3Jt
YW5jZSBpc3N1ZSBoYXZlIGJlZW4gYWRkcmVzc2VkLgo+ID4gCj4gPiBJcyB0aGUgYmxvY2tlciBi
dWcganVzdCBub3QgY2xvc2VkIGJlY2F1c2Ugbm8tb25lIHRob3VnaHQgdG8gZG8gaXQ6Cj4gPiAK
PiA+IGh0dHBzOi8vYnVnemlsbGEua2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MzgxCj4g
PiAKPiA+ICh3ZSBoYXZlIGNvbmZpcm1lZCB0aGF0IHRoaXMgaXNzdWUgaXMgbm93IGZpeGVkIHdp
dGggdGhlIG9yaWdpbmFsCj4gPiByZXBvcnRlcj8pCj4gCj4gRnJvbSBhIGRldmVsb3BlciB2aWV3
LCB0aGlzIGlzc3VlIGlzIGZpeGVkIGJ5IHRoZSBmb2xsb3dpbmcgY29tbWl0Ogo+IDNhMGE1Mjk5
NyhibG9jaywgc2NzaTogTWFrZSBTQ1NJIHF1aWVzY2UgYW5kIHJlc3VtZSB3b3JrIHJlbGlhYmx5
KSwKPiBhbmQgaXQgaXMgdmVyaWZpZWQgYnkga2VybmVsIGxpc3QgcmVwb3J0ZXIuCgpJIG5ldmVy
IHNlZW4gYW55IHN1c3BlbmQgLyBoaWJlcm5hdGUgcmVsYXRlZCBpc3N1ZXMgd2l0aCBibGstbXEg
KyBiZnEgc2luY2UgCnRoZW4uIFVzaW5nIGhlYXZpbHkgdXRpbGl6ZWQgQlRSRlMgZHVhbCBTU0Qg
UkFJRCAxLgoKJSBlZ3JlcCAiTVF8QkZRIiAvYm9vdC9jb25maWctNC4xNS4wLXRwNTIwLWJ0cmZz
dHJpbSsKQ09ORklHX1BPU0lYX01RVUVVRT15CkNPTkZJR19QT1NJWF9NUVVFVUVfU1lTQ1RMPXkK
Q09ORklHX0JMS19XQlRfTVE9eQpDT05GSUdfQkxLX01RX1BDST15CkNPTkZJR19CTEtfTVFfVklS
VElPPXkKQ09ORklHX01RX0lPU0NIRURfREVBRExJTkU9bQpDT05GSUdfTVFfSU9TQ0hFRF9LWUJF
Uj1tCkNPTkZJR19JT1NDSEVEX0JGUT1tCkNPTkZJR19CRlFfR1JPVVBfSU9TQ0hFRD15CkNPTkZJ
R19ORVRfU0NIX01RUFJJTz1tCiMgQ09ORklHX1NDU0lfTVFfREVGQVVMVCBpcyBub3Qgc2V0CiMg
Q09ORklHX0RNX01RX0RFRkFVTFQgaXMgbm90IHNldApDT05GSUdfRE1fQ0FDSEVfU01RPW0KCiUg
Y2F0IC9wcm9jL2NtZGxpbmUgCkJPT1RfSU1BR0U9L3ZtbGludXotNC4xNS4wLXRwNTIwLWJ0cmZz
dHJpbSsgcm9vdD1VVUlEPVvigKZdIHJvIApyb290ZmxhZ3M9c3Vidm9sPWRlYmlhbiByZXN1bWU9
L2Rldi9tYXBwZXIvc2F0YS1zd2FwIGluaXQ9L2Jpbi9zeXN0ZW1kIAp0aGlua3BhZF9hY3BpLmZh
bl9jb250cm9sPTEgc3lzdGVtZC5yZXN0b3JlX3N0YXRlPTAgc2NzaV9tb2QudXNlX2Jsa19tcT0x
CgolIGNhdCAvc3lzL2Jsb2NrL3NkYS9xdWV1ZS9zY2hlZHVsZXIgCltiZnFdIG5vbmUKClRoYW5r
cywKLS0gCk1hcnRpbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpMc2YtcGMgbWFpbGluZyBsaXN0CkxzZi1wY0BsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9y
ZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9sc2Yt
cGMK
WARNING: multiple messages have this Message-ID (diff)
From: martin@lichtvoll.de (Martin Steigerwald)
Subject: [LSF/MM TOPIC] Two blk-mq related topics
Date: Tue, 30 Jan 2018 09:33:18 +0100 [thread overview]
Message-ID: <1831727.Vh41F2Boqi@merkaba> (raw)
In-Reply-To: <20180130012408.GD17176@ming.t460p>
Ming Lei - 30.01.18, 02:24:
> > > SCSI_MQ is enabled on V3.17 firstly, but disabled at default. In
> > > V4.13-rc1, it is enabled at default, but later the patch is reverted
> > > in V4.13-rc7, and becomes disabled at default too.
> > >
> > > Now both the original reported PM issue(actually SCSI quiesce) and
> > > the sequential IO performance issue have been addressed.
> >
> > Is the blocker bug just not closed because no-one thought to do it:
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=178381
> >
> > (we have confirmed that this issue is now fixed with the original
> > reporter?)
>
> From a developer view, this issue is fixed by the following commit:
> 3a0a52997(block, scsi: Make SCSI quiesce and resume work reliably),
> and it is verified by kernel list reporter.
I never seen any suspend / hibernate related issues with blk-mq + bfq since
then. Using heavily utilized BTRFS dual SSD RAID 1.
% egrep "MQ|BFQ" /boot/config-4.15.0-tp520-btrfstrim+
CONFIG_POSIX_MQUEUE=y
CONFIG_POSIX_MQUEUE_SYSCTL=y
CONFIG_BLK_WBT_MQ=y
CONFIG_BLK_MQ_PCI=y
CONFIG_BLK_MQ_VIRTIO=y
CONFIG_MQ_IOSCHED_DEADLINE=m
CONFIG_MQ_IOSCHED_KYBER=m
CONFIG_IOSCHED_BFQ=m
CONFIG_BFQ_GROUP_IOSCHED=y
CONFIG_NET_SCH_MQPRIO=m
# CONFIG_SCSI_MQ_DEFAULT is not set
# CONFIG_DM_MQ_DEFAULT is not set
CONFIG_DM_CACHE_SMQ=m
% cat /proc/cmdline
BOOT_IMAGE=/vmlinuz-4.15.0-tp520-btrfstrim+ root=UUID=[?] ro
rootflags=subvol=debian resume=/dev/mapper/sata-swap init=/bin/systemd
thinkpad_acpi.fan_control=1 systemd.restore_state=0 scsi_mod.use_blk_mq=1
% cat /sys/block/sda/queue/scheduler
[bfq] none
Thanks,
--
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Steigerwald <martin@lichtvoll.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
John Garry <john.garry@huawei.com>,
lsf-pc@lists.linux-foundation.org, Linux-scsi@vger.kernel.org,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [LSF/MM TOPIC] Two blk-mq related topics
Date: Tue, 30 Jan 2018 09:33:18 +0100 [thread overview]
Message-ID: <1831727.Vh41F2Boqi@merkaba> (raw)
In-Reply-To: <20180130012408.GD17176@ming.t460p>
Ming Lei - 30.01.18, 02:24:
> > > SCSI_MQ is enabled on V3.17 firstly, but disabled at default. In
> > > V4.13-rc1, it is enabled at default, but later the patch is reverted
> > > in V4.13-rc7, and becomes disabled at default too.
> > >
> > > Now both the original reported PM issue(actually SCSI quiesce) and
> > > the sequential IO performance issue have been addressed.
> >
> > Is the blocker bug just not closed because no-one thought to do it:
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=178381
> >
> > (we have confirmed that this issue is now fixed with the original
> > reporter?)
>
> From a developer view, this issue is fixed by the following commit:
> 3a0a52997(block, scsi: Make SCSI quiesce and resume work reliably),
> and it is verified by kernel list reporter.
I never seen any suspend / hibernate related issues with blk-mq + bfq since
then. Using heavily utilized BTRFS dual SSD RAID 1.
% egrep "MQ|BFQ" /boot/config-4.15.0-tp520-btrfstrim+
CONFIG_POSIX_MQUEUE=y
CONFIG_POSIX_MQUEUE_SYSCTL=y
CONFIG_BLK_WBT_MQ=y
CONFIG_BLK_MQ_PCI=y
CONFIG_BLK_MQ_VIRTIO=y
CONFIG_MQ_IOSCHED_DEADLINE=m
CONFIG_MQ_IOSCHED_KYBER=m
CONFIG_IOSCHED_BFQ=m
CONFIG_BFQ_GROUP_IOSCHED=y
CONFIG_NET_SCH_MQPRIO=m
# CONFIG_SCSI_MQ_DEFAULT is not set
# CONFIG_DM_MQ_DEFAULT is not set
CONFIG_DM_CACHE_SMQ=m
% cat /proc/cmdline
BOOT_IMAGE=/vmlinuz-4.15.0-tp520-btrfstrim+ root=UUID=[…] ro
rootflags=subvol=debian resume=/dev/mapper/sata-swap init=/bin/systemd
thinkpad_acpi.fan_control=1 systemd.restore_state=0 scsi_mod.use_blk_mq=1
% cat /sys/block/sda/queue/scheduler
[bfq] none
Thanks,
--
Martin
next prev parent reply other threads:[~2018-01-30 8:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 15:46 [LSF/MM TOPIC] Two blk-mq related topics Ming Lei
2018-01-29 15:46 ` Ming Lei
2018-01-29 20:40 ` Mike Snitzer
2018-01-29 20:40 ` Mike Snitzer
2018-01-30 1:27 ` [Lsf-pc] " Ming Lei
2018-01-30 1:27 ` Ming Lei
2018-01-30 1:27 ` Ming Lei
2018-01-29 20:56 ` James Bottomley
2018-01-29 20:56 ` James Bottomley
2018-01-29 21:00 ` Jens Axboe
2018-01-29 21:00 ` Jens Axboe
2018-01-29 23:46 ` James Bottomley
2018-01-29 23:46 ` James Bottomley
2018-01-30 1:47 ` Jens Axboe
2018-01-30 1:47 ` Jens Axboe
2018-01-30 10:08 ` Johannes Thumshirn
2018-01-30 10:08 ` Johannes Thumshirn
2018-01-30 10:08 ` Johannes Thumshirn
2018-01-30 10:50 ` Mel Gorman
2018-01-30 10:50 ` Mel Gorman
2018-01-30 1:24 ` Ming Lei
2018-01-30 1:24 ` Ming Lei
2018-01-30 8:33 ` Martin Steigerwald [this message]
2018-01-30 8:33 ` Martin Steigerwald
2018-01-30 8:33 ` Martin Steigerwald
2018-01-30 10:33 ` John Garry
2018-01-30 10:33 ` John Garry
2018-01-30 10:33 ` John Garry
2018-02-07 10:55 ` John Garry
2018-02-07 10:55 ` John Garry
2018-02-07 10:55 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1831727.Vh41F2Boqi@merkaba \
--to=martin@lichtvoll.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Linux-scsi@vger.kernel.org \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.