All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Rasmus Rohde <rohde@duff.dk>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
	nfs@lists.sourceforge.net, linux-fsdevel@vger.kernel.org
Subject: Re: [NFS] [PATCH] Make UDF exportable
Date: Thu, 7 Feb 2008 14:44:00 +1100	[thread overview]
Message-ID: <18346.32384.780598.485949@notabene.brown> (raw)
In-Reply-To: message from Rasmus Rohde on Wednesday February 6

On Wednesday February 6, rohde@duff.dk wrote:
> > > +	dotdot.d_name.name = "..";
> > > +	dotdot.d_name.len = 2;
> > > +
> > > +	lock_kernel();
> > > +	if (!udf_find_entry(child->d_inode, &dotdot, &fibh, &cfi))
> > > +		goto out_unlock;
> >   Have you ever tried this? I think this could never work. UDF doesn't have
> > entry named .. in a directory. You have to search for an entry that has
> > in fileCharacteristics set bit FID_FILE_CHAR_PARENT. Maybe you could
> > hack-around udf_find_entry() to recognize .. dentry and do the search
> > accordingly.
> Probably not. I just tested that I could read files and navigate the
> directory structure. However looking into UDF I think you are right - it
> will fail.
> I have extended udf_find_entry() to do an explicit check based on
> fileCharacteristics as you propose.
> How do I actually test this case?

 - Mount the filesystem from the server.
 - 'cd' a few directories down into the filesystem.
 - reboot the server(1)
 - on the client 'ls -l'.

(1) A full reboot isn't needed.  Just unexport, unmount, remount,
    re-export on the server.

alternately, use a non-linux client and cd down into the filesystem
and
    ls -l ..

NeilBrown


  parent reply	other threads:[~2008-02-07  3:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 20:53 [NFS] [PATCH] Make UDF exportable Rasmus Rohde
     [not found] ` <1201726404.2976.8.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-05 10:29   ` Christoph Hellwig
2008-02-05 10:29 ` Christoph Hellwig
2008-02-05 17:44   ` Rasmus Rohde
2008-02-05 19:26     ` Rasmus Rohde
     [not found]     ` <1202233464.12188.43.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-05 19:26       ` Rasmus Rohde
2008-02-06 18:08     ` Jan Kara
     [not found]       ` <20080206180850.GD3475-pwKtmJkCtMINMLpHRKhSow@public.gmane.org>
2008-02-06 20:58         ` Rasmus Rohde
2008-02-06 20:58       ` Rasmus Rohde
     [not found]         ` <1202331482.2727.8.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-07  3:37           ` Christoph Hellwig
2008-02-07  5:45           ` Christoph Hellwig
2008-02-07  3:37         ` Christoph Hellwig
2008-02-07  3:44         ` Neil Brown [this message]
2008-02-07  3:44         ` Neil Brown
2008-02-07  5:45         ` Christoph Hellwig
2008-02-07  7:06           ` Rasmus Rohde
2008-02-07  7:06           ` Rasmus Rohde
2008-02-07 14:48             ` Jan Kara
     [not found]               ` <20080207144859.GJ6140-pwKtmJkCtMINMLpHRKhSow@public.gmane.org>
2008-02-07 15:02                 ` Rasmus Rohde
2008-02-07 15:02                   ` Rasmus Rohde
2008-02-07 15:13                   ` Jan Kara
     [not found]                   ` <1202396577.18175.2.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-04-29 14:33                     ` Christoph Hellwig
2008-04-29 14:33                   ` Christoph Hellwig
2008-04-30 15:41                     ` Jan Kara
2008-04-30 15:41                     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18346.32384.780598.485949@notabene.brown \
    --to=neilb@suse.de \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=nfs@lists.sourceforge.net \
    --cc=rohde@duff.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.