From: Christoph Hellwig <hch@infradead.org>
To: Rasmus Rohde <rohde@duff.dk>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
nfs@lists.sourceforge.net, linux-fsdevel@vger.kernel.org
Subject: Re: [NFS] [PATCH] Make UDF exportable
Date: Wed, 6 Feb 2008 22:37:51 -0500 [thread overview]
Message-ID: <20080207033751.GA26792@infradead.org> (raw)
In-Reply-To: <1202331482.2727.8.camel@localhost.localdomain>
On Wed, Feb 06, 2008 at 09:58:02PM +0100, Rasmus Rohde wrote:
> Probably not. I just tested that I could read files and navigate the
> directory structure. However looking into UDF I think you are right - it
> will fail.
> I have extended udf_find_entry() to do an explicit check based on
> fileCharacteristics as you propose.
> How do I actually test this case?
Testing this is pretty hard. You export a filesystem, then cd somewhere
deep into a directory hiearchy in there. Then unexport the filesystem
and unmount on the server. mount it back on the server, export it again
and do something with a file from the directory you've cd into before
the unmount. Make sure you have a printk in your get_parent method
to make sure you're really hitting it.
Btw, I think it would be nicer to opencode the .. lookup in get_parent
instead of changing udf_find_entry. The lookup for .. is not needed
by anything else, and get_parent only looks for it so it's a natural
place to opencode it there.
next prev parent reply other threads:[~2008-02-07 3:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 20:53 [NFS] [PATCH] Make UDF exportable Rasmus Rohde
2008-02-05 10:29 ` Christoph Hellwig
2008-02-05 17:44 ` Rasmus Rohde
[not found] ` <1202233464.12188.43.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-05 19:26 ` Rasmus Rohde
2008-02-05 19:26 ` Rasmus Rohde
2008-02-06 18:08 ` Jan Kara
2008-02-06 20:58 ` Rasmus Rohde
2008-02-07 3:37 ` Christoph Hellwig [this message]
[not found] ` <1202331482.2727.8.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-07 3:37 ` Christoph Hellwig
2008-02-07 5:45 ` Christoph Hellwig
2008-02-07 3:44 ` Neil Brown
2008-02-07 3:44 ` Neil Brown
2008-02-07 5:45 ` Christoph Hellwig
2008-02-07 7:06 ` Rasmus Rohde
2008-02-07 7:06 ` Rasmus Rohde
2008-02-07 14:48 ` Jan Kara
[not found] ` <20080207144859.GJ6140-pwKtmJkCtMINMLpHRKhSow@public.gmane.org>
2008-02-07 15:02 ` Rasmus Rohde
2008-02-07 15:02 ` Rasmus Rohde
2008-02-07 15:13 ` Jan Kara
[not found] ` <1202396577.18175.2.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-04-29 14:33 ` Christoph Hellwig
2008-04-29 14:33 ` Christoph Hellwig
2008-04-30 15:41 ` Jan Kara
2008-04-30 15:41 ` Jan Kara
[not found] ` <20080206180850.GD3475-pwKtmJkCtMINMLpHRKhSow@public.gmane.org>
2008-02-06 20:58 ` Rasmus Rohde
[not found] ` <1201726404.2976.8.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-05 10:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207033751.GA26792@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=rohde@duff.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.