Re: [B.A.T.M.A.N.] [PATCHv4 1/4] batman-adv: Remove explicit compat.h include and split compat.h

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On Friday, April 17, 2015 19:40:27 Sven Eckelmann wrote:
> The current approach for the compat layer is to include the compat.h file at
> exactly the right time to provide additional functionality and to live
> patch the batman-adv sources. This has the problem that the compat.h file
> becomes harder to read over time. Also live patching and adding of missing
> functionality partially conflict. This becomes obvious when the include
> order in some files is different compared to the one the author of an
> compat.h entry expected.
> 
> A different approach is to inject intermediate header files which add
> additional features. This allows to reduce the size of compat.h and only
> leaves the live patching part in it. The compat.h can then added
> automatically to each compile run before anything else is included.
> compat.h has therefore the control which headers must be included before
> the live patching of the batman-adv source can begin.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>

Applied in revision 8746f0f.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]