From: Sven Eckelmann <sven@narfation.org>
To: Marek Lindner <mareklindner@neomailbox.ch>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv4 3/4] batman-adv: Remove unused IFF_BRIDGE_PORT live patching hack
Date: Tue, 21 Apr 2015 08:04:41 +0200 [thread overview]
Message-ID: <8826381.MUao5dBNO2@sven-edge> (raw)
In-Reply-To: <2849660.eB6RnOYSlL@voltaire>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
> > diff --git a/compat.h b/compat.h
> > index 35e3dbd..9871a23 100644
> > --- a/compat.h
> > +++ b/compat.h
> > @@ -59,8 +59,6 @@
> >
> > #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 36)
> >
> > -#define IFF_BRIDGE_PORT 0 || (hard_iface->net_dev->br_port ? 1 : 0)
> > -
> >
> > /* hack for dev->addr_assign_type &= ~NET_ADDR_RANDOM; */
> > #define addr_assign_type ifindex
>
> The macro is used in compat.h line 55, is it not ?
IFF_BRIDGE_PORT appears in this line but here is the context:
#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 36)
HERE IT IS *NOT* USED
#elif LINUX_VERSION_CODE < KERNEL_VERSION(3, 9, 0)
HERE IT IS USED
#endif /* < KERNEL_VERSION(2, 6, 36) */
The IFF_BRIDGE_PORT (which I call unused( is only required in this other
compat hack when the kernel is >= 2.6.36 and < 3.9.0. But the one I want to
remove is only for kernels < 2.6.36.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-21 6:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 17:40 [B.A.T.M.A.N.] [PATCHv4 1/4] batman-adv: Remove explicit compat.h include and split compat.h Sven Eckelmann
2015-04-17 17:40 ` [B.A.T.M.A.N.] [PATCHv4 2/4] batman-adv: Add required to includes to all files Sven Eckelmann
2015-04-20 16:25 ` Sven Eckelmann
2015-04-21 3:46 ` Marek Lindner
2015-04-17 17:40 ` [B.A.T.M.A.N.] [PATCHv4 3/4] batman-adv: Remove unused IFF_BRIDGE_PORT live patching hack Sven Eckelmann
2015-04-21 3:48 ` Marek Lindner
2015-04-21 6:04 ` Sven Eckelmann [this message]
2015-04-21 8:53 ` Marek Lindner
2015-04-17 17:40 ` [B.A.T.M.A.N.] [PATCHv4 4/4] batman-adv: Automatically create nested kfree_rcu helper functions Sven Eckelmann
2015-04-21 3:52 ` Marek Lindner
2015-04-21 6:35 ` Sven Eckelmann
2015-04-21 9:01 ` Marek Lindner
2015-04-20 16:12 ` [B.A.T.M.A.N.] [PATCHv5 1/4] batman-adv: Remove explicit compat.h include and split compat.h Sven Eckelmann
2015-04-21 3:41 ` [B.A.T.M.A.N.] [PATCHv4 " Marek Lindner
2015-04-21 6:19 ` Sven Eckelmann
2015-04-21 9:02 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8826381.MUao5dBNO2@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.