From: Tomasz Figa <tomasz.figa@gmail.com>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Ajay Kumar <ajaykumar.rs@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
jg1.han@samsung.com, devicetree-discuss@lists.ozlabs.org,
FlorianSchandinat@gmx.de, thomas.ab@samsung.com
Subject: Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver
Date: Fri, 12 Oct 2012 22:22:21 +0000 [thread overview]
Message-ID: <1836310.KzLg5kfvv2@flatron> (raw)
In-Reply-To: <5078964F.4000902@gmail.com>
On Saturday 13 of October 2012 00:14:39 Sylwester Nawrocki wrote:
> On 10/12/2012 11:54 PM, Tomasz Figa wrote:
> >>> + if (of_get_property(dp_node, "interlaced", NULL))
> >>> + dp_video_config->interlaced = 1;
> >>
> >> of_property_read_bool() could also be used here.
> >
> > Wouldn't it make the property mandatory?
>
> No, it wouldn't. of_property_read_bool() uses of_find_property()
> internally. It just returns true if property is found or false
> otherwise.
Right, sorry. I thought that all of_property_read_* return error in case
of missing property.
> Anyway, it appears of_get_property(..., NULL) pattern
> is commonly used for boolean properties.
I guess all three of them should be fine in this case, but since there is
a dedicated function for bool, it might be the best solution here indeed.
Best regards,
Tomasz Figa
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Ajay Kumar <ajaykumar.rs@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
jg1.han@samsung.com, devicetree-discuss@lists.ozlabs.org,
FlorianSchandinat@gmx.de, thomas.ab@samsung.com
Subject: Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver
Date: Sat, 13 Oct 2012 00:22:21 +0200 [thread overview]
Message-ID: <1836310.KzLg5kfvv2@flatron> (raw)
In-Reply-To: <5078964F.4000902@gmail.com>
On Saturday 13 of October 2012 00:14:39 Sylwester Nawrocki wrote:
> On 10/12/2012 11:54 PM, Tomasz Figa wrote:
> >>> + if (of_get_property(dp_node, "interlaced", NULL))
> >>> + dp_video_config->interlaced = 1;
> >>
> >> of_property_read_bool() could also be used here.
> >
> > Wouldn't it make the property mandatory?
>
> No, it wouldn't. of_property_read_bool() uses of_find_property()
> internally. It just returns true if property is found or false
> otherwise.
Right, sorry. I thought that all of_property_read_* return error in case
of missing property.
> Anyway, it appears of_get_property(..., NULL) pattern
> is commonly used for boolean properties.
I guess all three of them should be fine in this case, but since there is
a dedicated function for bool, it might be the best solution here indeed.
Best regards,
Tomasz Figa
next prev parent reply other threads:[~2012-10-12 22:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 11:18 [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver Ajay Kumar
2012-10-12 20:47 ` Ajay Kumar
2012-10-12 11:19 ` [PATCH V5 2/2] video: exynos_dp: device tree documentation Ajay Kumar
2012-10-12 20:47 ` Ajay Kumar
2012-10-15 6:13 ` Jingoo Han
2012-10-15 6:13 ` Jingoo Han
2012-10-12 21:44 ` [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver Sylwester Nawrocki
2012-10-12 21:44 ` Sylwester Nawrocki
2012-10-12 21:54 ` Tomasz Figa
2012-10-12 21:54 ` Tomasz Figa
2012-10-12 22:14 ` Sylwester Nawrocki
2012-10-12 22:14 ` Sylwester Nawrocki
2012-10-12 22:22 ` Tomasz Figa [this message]
2012-10-12 22:22 ` Tomasz Figa
2012-10-15 8:14 ` Jingoo Han
2012-10-15 8:14 ` Jingoo Han
2012-10-15 21:14 ` Sylwester Nawrocki
2012-10-15 21:14 ` Sylwester Nawrocki
2012-10-16 2:02 ` Jingoo Han
2012-10-16 2:02 ` Jingoo Han
2012-10-16 11:07 ` Sylwester Nawrocki
2012-10-16 11:07 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1836310.KzLg5kfvv2@flatron \
--to=tomasz.figa@gmail.com \
--cc=FlorianSchandinat@gmx.de \
--cc=ajaykumar.rs@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.