All of lore.kernel.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] phy: Add Cadence D-PHY support
Date: Wed, 05 Sep 2018 16:48:27 +0300	[thread overview]
Message-ID: <1838745.9zNmGlpGXc@avalon> (raw)
In-Reply-To: <d50a5f0750647dcc09ef52411641b628161b362e.1536138624.git-series.maxime.ripard@bootlin.com>

Hi Maxime,

Thank you for the patch.

On Wednesday, 5 September 2018 12:16:40 EEST Maxime Ripard wrote:
> Cadence has designed a D-PHY that can be used by the, currently in tree,
> DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers.
> 
> Only the DSI driver has an ad-hoc driver for that phy at the moment, while
> the v4l2 drivers are completely missing any phy support. In order to make
> that phy support available to all these drivers, without having to
> duplicate that code three times, let's create a generic phy framework
> driver.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  drivers/phy/Kconfig             |   1 +-
>  drivers/phy/Makefile            |   1 +-
>  drivers/phy/cadence/Kconfig     |  13 +-
>  drivers/phy/cadence/Makefile    |   1 +-
>  drivers/phy/cadence/cdns-dphy.c | 499 +++++++++++++++++++++++++++++++++-

Should the DT bindings be split from Documentation/devicetree/bindings/
display/bridge/cdns,dsi.txt ?

>  5 files changed, 515 insertions(+)
>  create mode 100644 drivers/phy/cadence/Kconfig
>  create mode 100644 drivers/phy/cadence/Makefile
>  create mode 100644 drivers/phy/cadence/cdns-dphy.c

[snip]

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Boris Brezillon <boris.brezillon@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-media@vger.kernel.org,
	Archit Taneja <architt@codeaurora.org>,
	Andrzej Hajda <a.hajda@samsung.com>, Chen-Yu Tsai <wens@csie.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	Krzysztof Witos <kwitos@cadence.com>,
	Rafal Ciepiela <rafalc@cadence.com>
Subject: Re: [PATCH 09/10] phy: Add Cadence D-PHY support
Date: Wed, 05 Sep 2018 16:48:27 +0300	[thread overview]
Message-ID: <1838745.9zNmGlpGXc@avalon> (raw)
In-Reply-To: <d50a5f0750647dcc09ef52411641b628161b362e.1536138624.git-series.maxime.ripard@bootlin.com>

Hi Maxime,

Thank you for the patch.

On Wednesday, 5 September 2018 12:16:40 EEST Maxime Ripard wrote:
> Cadence has designed a D-PHY that can be used by the, currently in tree,
> DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers.
> 
> Only the DSI driver has an ad-hoc driver for that phy at the moment, while
> the v4l2 drivers are completely missing any phy support. In order to make
> that phy support available to all these drivers, without having to
> duplicate that code three times, let's create a generic phy framework
> driver.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  drivers/phy/Kconfig             |   1 +-
>  drivers/phy/Makefile            |   1 +-
>  drivers/phy/cadence/Kconfig     |  13 +-
>  drivers/phy/cadence/Makefile    |   1 +-
>  drivers/phy/cadence/cdns-dphy.c | 499 +++++++++++++++++++++++++++++++++-

Should the DT bindings be split from Documentation/devicetree/bindings/
display/bridge/cdns,dsi.txt ?

>  5 files changed, 515 insertions(+)
>  create mode 100644 drivers/phy/cadence/Kconfig
>  create mode 100644 drivers/phy/cadence/Makefile
>  create mode 100644 drivers/phy/cadence/cdns-dphy.c

[snip]

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2018-09-05 13:48 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  9:16 [PATCH 00/10] phy: Add configuration interface for MIPI D-PHY devices Maxime Ripard
2018-09-05  9:16 ` Maxime Ripard
2018-09-05  9:16 ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 01/10] phy: Add MIPI D-PHY mode Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05 13:46   ` Laurent Pinchart
2018-09-05 13:46     ` Laurent Pinchart
2018-09-05  9:16 ` [PATCH 02/10] phy: Add configuration interface Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05 13:39   ` Laurent Pinchart
2018-09-05 13:39     ` Laurent Pinchart
2018-09-05 13:39     ` Laurent Pinchart
2018-09-06 14:48     ` Maxime Ripard
2018-09-06 14:48       ` Maxime Ripard
2018-09-06 14:48       ` Maxime Ripard
2018-09-06 16:24       ` Andrew Lunn
2018-09-06 16:24         ` Andrew Lunn
2018-09-07  9:01         ` Maxime Ripard
2018-09-07  9:01           ` Maxime Ripard
2018-09-07  9:01           ` Maxime Ripard
2018-09-06 16:51       ` Laurent Pinchart
2018-09-06 16:51         ` Laurent Pinchart
2018-09-06 16:51         ` Laurent Pinchart
2018-09-07  9:07         ` Maxime Ripard
2018-09-07  9:07           ` Maxime Ripard
2018-09-07  9:07           ` Maxime Ripard
2018-09-06  9:27   ` Kishon Vijay Abraham I
2018-09-06  9:27     ` Kishon Vijay Abraham I
2018-09-06  9:27     ` Kishon Vijay Abraham I
2018-09-06 14:56     ` Maxime Ripard
2018-09-06 14:56       ` Maxime Ripard
2018-09-06 14:56       ` Maxime Ripard
2018-09-12  7:42       ` Kishon Vijay Abraham I
2018-09-12  7:42         ` Kishon Vijay Abraham I
2018-09-12  7:42         ` Kishon Vijay Abraham I
2018-09-12  8:42         ` Maxime Ripard
2018-09-12  8:42           ` Maxime Ripard
2018-09-12  8:42           ` Maxime Ripard
2018-09-14  8:48           ` Kishon Vijay Abraham I
2018-09-14  8:48             ` Kishon Vijay Abraham I
2018-09-14  8:48             ` Kishon Vijay Abraham I
2018-09-19 12:14             ` Maxime Ripard
2018-09-19 12:14               ` Maxime Ripard
2018-09-19 12:14               ` Maxime Ripard
2018-09-21 14:18               ` Maxime Ripard
2018-09-21 14:18                 ` Maxime Ripard
2018-09-24  8:48               ` Kishon Vijay Abraham I
2018-09-24  8:48                 ` Kishon Vijay Abraham I
2018-09-24  8:48                 ` Kishon Vijay Abraham I
2018-09-24  9:54                 ` Maxime Ripard
2018-09-24  9:54                   ` Maxime Ripard
2018-09-24  9:54                   ` Maxime Ripard
2018-09-24 11:55                   ` Kishon Vijay Abraham I
2018-09-24 11:55                     ` Kishon Vijay Abraham I
2018-09-24 11:55                     ` Kishon Vijay Abraham I
2018-09-24 12:19                     ` Maxime Ripard
2018-09-24 12:19                       ` Maxime Ripard
2018-09-24 12:19                       ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 03/10] phy: Add MIPI D-PHY configuration options Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05 13:43   ` Laurent Pinchart
2018-09-05 13:43     ` Laurent Pinchart
2018-09-07  8:56     ` Maxime Ripard
2018-09-07  8:56       ` Maxime Ripard
2018-09-07 14:50       ` Laurent Pinchart
2018-09-07 14:50         ` Laurent Pinchart
2018-09-07 14:50         ` Laurent Pinchart
2018-09-10 14:18         ` Maxime Ripard
2018-09-10 14:18           ` Maxime Ripard
2018-09-10 14:18           ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 04/10] phy: dphy: Add configuration helpers Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05 13:46   ` Laurent Pinchart
2018-09-05 13:46     ` Laurent Pinchart
2018-09-05 13:46     ` Laurent Pinchart
2018-09-07 13:37     ` Maxime Ripard
2018-09-07 13:37       ` Maxime Ripard
2018-09-07 13:37       ` Maxime Ripard
2018-09-07 14:26       ` Laurent Pinchart
2018-09-07 14:26         ` Laurent Pinchart
2018-09-10 14:16         ` Maxime Ripard
2018-09-10 14:16           ` Maxime Ripard
2018-09-10 14:28           ` Laurent Pinchart
2018-09-10 14:28             ` Laurent Pinchart
2018-09-05  9:16 ` [PATCH 05/10] sun6i: dsi: Convert to generic phy handling Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 06/10] phy: Move Allwinner A31 D-PHY driver to drivers/phy/ Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 07/10] drm/bridge: cdns: Remove mode_check test Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 08/10] drm/bridge: cdns: Separate DSI and D-PHY configuration Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 09/10] phy: Add Cadence D-PHY support Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard
2018-09-05 13:48   ` Laurent Pinchart [this message]
2018-09-05 13:48     ` Laurent Pinchart
2018-09-07 13:38     ` Maxime Ripard
2018-09-07 13:38       ` Maxime Ripard
2018-09-07 13:38       ` Maxime Ripard
2018-09-05  9:16 ` [PATCH 10/10] drm/bridge: cdns: Convert to phy framework Maxime Ripard
2018-09-05  9:16   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1838745.9zNmGlpGXc@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.