All of lore.kernel.org
 help / color / mirror / Atom feed
From: GitHub issues - opened <github@alsa-project.org>
To: alsa-devel@alsa-project.org
Subject: New include guard in seq_event.h breaks DSSI header
Date: Sat, 17 May 2025 11:53:28 +0200 (CEST)	[thread overview]
Message-ID: <184047ce0ad2f400-webhooks-bot@alsa-project.org> (raw)
In-Reply-To: <184047ce0acdbd00-webhooks-bot@alsa-project.org>

alsa-project/alsa-lib issue #455 was opened from cannam:

Hello! I am one of the original authors of [DSSI](https://dssi.sourceforge.net/), a soft-synth API that was created about 20 years ago. It's not an active project, it was basically "done" by about 2011 but is still used in a number of applications.

The DSSI header `dssi.h` includes `<alsa/seq_event.h>` in order to pick up a structure for MIDI-like events.

I see that following a report of breakage in #431, a guard was added to seq_event.h in ea8972c to warn against including that header directly.

The official fix seems to be to include the whole of `<alsa/asoundlib.h>`, and that is what packagers appear to be patching the DSSI header with currently (and I see it is also what the guard does itself after emitting the warning). Unfortunately from the perspective of DSSI as an API, that isn't really a fix at all because all we need is an event structure - there is no other dependency on ALSA as a library and there was never any intention to require linking with ALSA.

Probably the historical error was to use an ALSA header at all, and the best option for us might be to duplicate enough of the contents of `seq_event.h` locally to sever the dependency that way.

But I thought I should first check whether you can suggest a better approach, for example whether you might be open to making it possible (again) to make use of `seq_event.h` specifically without pulling in a dependency on everything else in ALSA.

Thank you!

Issue URL     : https://github.com/alsa-project/alsa-lib/issues/455
Repository URL: https://github.com/alsa-project/alsa-lib

       reply	other threads:[~2025-05-17  9:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <184047ce0acdbd00-webhooks-bot@alsa-project.org>
2025-05-17  9:53 ` GitHub issues - opened [this message]
     [not found] <18405398c351bd00-webhooks-bot@alsa-project.org>
2025-05-17 13:29 ` New include guard in seq_event.h breaks DSSI header GitHub issues - edited

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=184047ce0ad2f400-webhooks-bot@alsa-project.org \
    --to=github@alsa-project.org \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.