Re: [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1

From: "Heiko Stübner" <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, Hsun Lai <i@chainsx.cn>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/6] arm64: dts: rockchip: add mmc aliases for 100ASK DshanPi A1
Date: Fri, 14 Nov 2025 00:00:19 +0100	[thread overview]
Message-ID: <1841407.VLH7GnMWUR@diego> (raw)
In-Reply-To: <20251101120010.41729-1-amadeus@jmu.edu.cn>

Hi,

Am Samstag, 1. November 2025, 13:00:05 Mitteleuropäische Normalzeit schrieb Chukun Pan:
> Add missing MMC aliases. Remove the max-frequency property
> from the MMC node, which is already defined in rk3576.dtsi.

please split this into 2 patches, one for the aliases, one for the
max-frequency removal.

Thanks
Heiko

> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
> index 59c172573cf8..9cbd3fae16ab 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-100ask-dshanpi-a1.dts
> @@ -19,6 +19,8 @@ / {
>  	aliases {
>  		ethernet0 = &gmac0;
>  		ethernet1 = &gmac1;
> +		mmc0 = &sdhci;
> +		mmc1 = &sdmmc;
>  	};
>  
>  	chosen {
> @@ -735,7 +737,6 @@ &sai6 {
>  &sdhci {
>  	bus-width = <8>;
>  	full-pwr-cycle-in-suspend;
> -	max-frequency = <200000000>;
>  	mmc-hs400-1_8v;
>  	mmc-hs400-enhanced-strobe;
>  	no-sdio;
> @@ -749,7 +750,6 @@ &sdmmc {
>  	cap-mmc-highspeed;
>  	cap-sd-highspeed;
>  	disable-wp;
> -	max-frequency = <200000000>;
>  	sd-uhs-sdr104;
>  	vmmc-supply = <&vcc_3v3_s3>;
>  	vqmmc-supply = <&vccio_sd_s0>;
> 