* [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask
@ 2023-03-10 9:28 Alexander Stein
2023-03-13 13:46 ` Frieder Schrempf
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2023-03-10 9:28 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Frieder Schrempf, Robin Gong
Cc: Alexander Stein, linux-kernel
This fixes a copy & paste error.
Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
Originally-from: Robin Gong <yibin.gong@nxp.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This diff is extracted from a downstream commit authored by Robin Gong.
I'm not sure if adding Originally-from: is enough here or I do have to
change From: as well.
drivers/regulator/pca9450-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index c84d95b11e9c..544e741f7108 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -265,7 +265,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = {
.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
.vsel_mask = BUCK2OUT_DVS0_MASK,
.enable_reg = PCA9450_REG_BUCK2CTRL,
- .enable_mask = BUCK1_ENMODE_MASK,
+ .enable_mask = BUCK2_ENMODE_MASK,
.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
.ramp_reg = PCA9450_REG_BUCK2CTRL,
.ramp_mask = BUCK2_RAMP_MASK,
@@ -509,7 +509,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = {
.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
.vsel_mask = BUCK2OUT_DVS0_MASK,
.enable_reg = PCA9450_REG_BUCK2CTRL,
- .enable_mask = BUCK1_ENMODE_MASK,
+ .enable_mask = BUCK2_ENMODE_MASK,
.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
.ramp_reg = PCA9450_REG_BUCK2CTRL,
.ramp_mask = BUCK2_RAMP_MASK,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask 2023-03-10 9:28 [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask Alexander Stein @ 2023-03-13 13:46 ` Frieder Schrempf 2023-03-13 14:21 ` Alexander Stein 0 siblings, 1 reply; 6+ messages in thread From: Frieder Schrempf @ 2023-03-13 13:46 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Robin Gong; +Cc: linux-kernel On 10.03.23 10:28, Alexander Stein wrote: > This fixes a copy & paste error. I would mention here, that this doesn't contain any functional changes as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK. > > Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver") > Originally-from: Robin Gong <yibin.gong@nxp.com> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > This diff is extracted from a downstream commit authored by Robin Gong. > I'm not sure if adding Originally-from: is enough here or I do have to > change From: as well. I never heard of "Originally-from:". Does this tag exist? Is it documented somewhere? I think that your tooling (git format-patch) should add a From: tag automatically if you correctly pick up a patch from someone else. Other than these formal issues the change itself looks good to me. > > drivers/regulator/pca9450-regulator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c > index c84d95b11e9c..544e741f7108 100644 > --- a/drivers/regulator/pca9450-regulator.c > +++ b/drivers/regulator/pca9450-regulator.c > @@ -265,7 +265,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { > .vsel_reg = PCA9450_REG_BUCK2OUT_DVS0, > .vsel_mask = BUCK2OUT_DVS0_MASK, > .enable_reg = PCA9450_REG_BUCK2CTRL, > - .enable_mask = BUCK1_ENMODE_MASK, > + .enable_mask = BUCK2_ENMODE_MASK, > .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, > .ramp_reg = PCA9450_REG_BUCK2CTRL, > .ramp_mask = BUCK2_RAMP_MASK, > @@ -509,7 +509,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { > .vsel_reg = PCA9450_REG_BUCK2OUT_DVS0, > .vsel_mask = BUCK2OUT_DVS0_MASK, > .enable_reg = PCA9450_REG_BUCK2CTRL, > - .enable_mask = BUCK1_ENMODE_MASK, > + .enable_mask = BUCK2_ENMODE_MASK, > .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, > .ramp_reg = PCA9450_REG_BUCK2CTRL, > .ramp_mask = BUCK2_RAMP_MASK, ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask 2023-03-13 13:46 ` Frieder Schrempf @ 2023-03-13 14:21 ` Alexander Stein 2023-03-13 14:38 ` Frieder Schrempf 0 siblings, 1 reply; 6+ messages in thread From: Alexander Stein @ 2023-03-13 14:21 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Robin Gong, Frieder Schrempf; +Cc: linux-kernel Hi Frieder, thanks for your comments. Am Montag, 13. März 2023, 14:46:08 CET schrieb Frieder Schrempf: > On 10.03.23 10:28, Alexander Stein wrote: > > This fixes a copy & paste error. > > I would mention here, that this doesn't contain any functional changes > as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK. That's a good idea. > > Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver") > > Originally-from: Robin Gong <yibin.gong@nxp.com> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > This diff is extracted from a downstream commit authored by Robin Gong. > > I'm not sure if adding Originally-from: is enough here or I do have to > > change From: as well. > > I never heard of "Originally-from:". Does this tag exist? Is it > documented somewhere? Well, it's not documented, but it pops up occasionally in some commits, e.g. 3fb906e7fabbb ("cgroup/cpuset: Don't filter offline CPUs in cpuset_cpus_allowed() for top cpuset tasks") I might be something only some maintainers accept though. > I think that your tooling (git format-patch) should add a From: tag > automatically if you correctly pick up a patch from someone else. Well, it's not exactly cherry-picked, but extracted from an existing commit [1], so that's maybe why my name has been put into From: while extracting. As the diff in this patch is not exactly the same as from the origin, I did not want to put Robin Gong into Signed-off-by. And I think having an author in From: but not in Signed-off-by: tag should not happen. Searching how I can still give credit I found Originally-from. If there is a better way to handle this, I'm ready to adapt to that. Best regards, Alexander [1] https://github.com/Freescale/linux-fslc/commit/ fe6b4f7a23a79637c6fb182fb1ea9136d953e3f7 > Other than these formal issues the change itself looks good to me. > > > drivers/regulator/pca9450-regulator.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/regulator/pca9450-regulator.c > > b/drivers/regulator/pca9450-regulator.c index c84d95b11e9c..544e741f7108 > > 100644 > > --- a/drivers/regulator/pca9450-regulator.c > > +++ b/drivers/regulator/pca9450-regulator.c > > @@ -265,7 +265,7 @@ static const struct pca9450_regulator_desc > > pca9450a_regulators[] = {> > > .vsel_reg = PCA9450_REG_BUCK2OUT_DVS0, > > .vsel_mask = BUCK2OUT_DVS0_MASK, > > .enable_reg = PCA9450_REG_BUCK2CTRL, > > > > - .enable_mask = BUCK1_ENMODE_MASK, > > + .enable_mask = BUCK2_ENMODE_MASK, > > > > .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, > > .ramp_reg = PCA9450_REG_BUCK2CTRL, > > .ramp_mask = BUCK2_RAMP_MASK, > > > > @@ -509,7 +509,7 @@ static const struct pca9450_regulator_desc > > pca9450bc_regulators[] = {> > > .vsel_reg = PCA9450_REG_BUCK2OUT_DVS0, > > .vsel_mask = BUCK2OUT_DVS0_MASK, > > .enable_reg = PCA9450_REG_BUCK2CTRL, > > > > - .enable_mask = BUCK1_ENMODE_MASK, > > + .enable_mask = BUCK2_ENMODE_MASK, > > > > .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, > > .ramp_reg = PCA9450_REG_BUCK2CTRL, > > .ramp_mask = BUCK2_RAMP_MASK, -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask 2023-03-13 14:21 ` Alexander Stein @ 2023-03-13 14:38 ` Frieder Schrempf 2023-04-21 11:57 ` Alexander Stein 0 siblings, 1 reply; 6+ messages in thread From: Frieder Schrempf @ 2023-03-13 14:38 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Robin Gong; +Cc: linux-kernel On 13.03.23 15:21, Alexander Stein wrote: > Hi Frieder, > > thanks for your comments. > > Am Montag, 13. März 2023, 14:46:08 CET schrieb Frieder Schrempf: >> On 10.03.23 10:28, Alexander Stein wrote: >>> This fixes a copy & paste error. >> >> I would mention here, that this doesn't contain any functional changes >> as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK. > > That's a good idea. > >>> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver") >>> Originally-from: Robin Gong <yibin.gong@nxp.com> >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>> --- >>> This diff is extracted from a downstream commit authored by Robin Gong. >>> I'm not sure if adding Originally-from: is enough here or I do have to >>> change From: as well. >> >> I never heard of "Originally-from:". Does this tag exist? Is it >> documented somewhere? > > Well, it's not documented, but it pops up occasionally in some commits, e.g. > 3fb906e7fabbb ("cgroup/cpuset: Don't filter offline CPUs in > cpuset_cpus_allowed() for top cpuset tasks") > I might be something only some maintainers accept though. > >> I think that your tooling (git format-patch) should add a From: tag >> automatically if you correctly pick up a patch from someone else. > > Well, it's not exactly cherry-picked, but extracted from an existing commit > [1], so that's maybe why my name has been put into From: while extracting. > As the diff in this patch is not exactly the same as from the origin, I did > not want to put Robin Gong into Signed-off-by. And I think having an author in > From: but not in Signed-off-by: tag should not happen. > Searching how I can still give credit I found Originally-from. If there is a > better way to handle this, I'm ready to adapt to that. Ok, good question. I currently have a similar case somewhere else and I'm also not really sure how to handle it properly. I don't think we are ever allowed to add a Signed-off-by tag for someone else. Maybe "Originally-from" is correct for this case but I never really like to use tags that aren't generally accepted or documented somewhere. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask 2023-03-13 14:38 ` Frieder Schrempf @ 2023-04-21 11:57 ` Alexander Stein 2023-04-21 12:02 ` Mark Brown 0 siblings, 1 reply; 6+ messages in thread From: Alexander Stein @ 2023-04-21 11:57 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Robin Gong, Frieder Schrempf; +Cc: linux-kernel Hi, Am Montag, 13. März 2023, 15:38:52 CEST schrieb Frieder Schrempf: > On 13.03.23 15:21, Alexander Stein wrote: > > Hi Frieder, > > > > thanks for your comments. > > > > Am Montag, 13. März 2023, 14:46:08 CET schrieb Frieder Schrempf: > >> On 10.03.23 10:28, Alexander Stein wrote: > >>> This fixes a copy & paste error. > >> > >> I would mention here, that this doesn't contain any functional changes > >> as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK. > > > > That's a good idea. > > > >>> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver") > >>> Originally-from: Robin Gong <yibin.gong@nxp.com> > >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > >>> --- > >>> This diff is extracted from a downstream commit authored by Robin Gong. > >>> I'm not sure if adding Originally-from: is enough here or I do have to > >>> change From: as well. > >> > >> I never heard of "Originally-from:". Does this tag exist? Is it > >> documented somewhere? > > > > Well, it's not documented, but it pops up occasionally in some commits, > > e.g. 3fb906e7fabbb ("cgroup/cpuset: Don't filter offline CPUs in > > cpuset_cpus_allowed() for top cpuset tasks") > > I might be something only some maintainers accept though. > > > >> I think that your tooling (git format-patch) should add a From: tag > >> automatically if you correctly pick up a patch from someone else. > > > > Well, it's not exactly cherry-picked, but extracted from an existing > > commit > > [1], so that's maybe why my name has been put into From: while extracting. > > As the diff in this patch is not exactly the same as from the origin, I > > did > > not want to put Robin Gong into Signed-off-by. And I think having an > > author in From: but not in Signed-off-by: tag should not happen. > > Searching how I can still give credit I found Originally-from. If there is > > a better way to handle this, I'm ready to adapt to that. > > Ok, good question. I currently have a similar case somewhere else and > I'm also not really sure how to handle it properly. I don't think we are > ever allowed to add a Signed-off-by tag for someone else. > Maybe "Originally-from" is correct for this case but I never really like > to use tags that aren't generally accepted or documented somewhere. Could some of the maintainers make a call here, how to address the original author where the change is taken from? Note: It is not cherry-picked, but only some hunks are taken. Thanks Best regards, Alexander -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask 2023-04-21 11:57 ` Alexander Stein @ 2023-04-21 12:02 ` Mark Brown 0 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2023-04-21 12:02 UTC (permalink / raw) To: Alexander Stein; +Cc: Liam Girdwood, Robin Gong, Frieder Schrempf, linux-kernel [-- Attachment #1: Type: text/plain, Size: 365 bytes --] On Fri, Apr 21, 2023 at 01:57:01PM +0200, Alexander Stein wrote: > Could some of the maintainers make a call here, how to address the original > author where the change is taken from? Note: It is not cherry-picked, but only > some hunks are taken. I don't particularly care so long as everyone involved who should be getting credit is reasonably happy. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-21 12:03 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-10 9:28 [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask Alexander Stein 2023-03-13 13:46 ` Frieder Schrempf 2023-03-13 14:21 ` Alexander Stein 2023-03-13 14:38 ` Frieder Schrempf 2023-04-21 11:57 ` Alexander Stein 2023-04-21 12:02 ` Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.