All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Prerna Saxena <prerna.saxena@nutanix.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org,
	marcandre lureau <marcandre.lureau@redhat.com>,
	peter maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table
Date: Thu, 8 Sep 2016 07:56:38 -0400 (EDT)	[thread overview]
Message-ID: <1848526494.767098.1473335798486.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <86AAE458-EC2F-4814-88A9-E3E7F93AD274@nutanix.com>

Hi

----- Original Message -----
> Regarding Patch 2/2:
> This patch seems to filter responses from set_mem_table only for certain
> updates of memory regions. It violates the definition of the REPLY_ACK
> feature. This feature expects the client to send a response for every call
> of set_mem_table. And here, qemu exits the set_mem_table() function in some
> cases without even waiting for the reply that is going to come in.
> 

Agreed with Prerna here,

Furthermore, I haven't followed closely the recents developments, and the commit message doesn't explain why it should not be necessary to sync the first time set-mem-table is called. Could you develop that?

thanks

  reply	other threads:[~2016-09-08 11:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08  8:34 [Qemu-devel] [PATCH 0/2] vhost-user: set_mem_table updates Maxime Coquelin
2016-09-08  8:34 ` [Qemu-devel] [PATCH 1/2] Revert "Revert "vhost-user: Attempt to fix a race with set_mem_table."" Maxime Coquelin
2016-09-08  8:34 ` [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table Maxime Coquelin
2016-09-08 11:33   ` Prerna Saxena
2016-09-08 11:56     ` Marc-André Lureau [this message]
2016-09-08 15:06       ` Michael S. Tsirkin
2016-09-08 15:17     ` Michael S. Tsirkin
2016-09-08 15:15   ` Michael S. Tsirkin
2016-09-12  7:27     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1848526494.767098.1473335798486.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=prerna.saxena@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.