From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH 2/2] lost_reset: return value rather than sequence number when zero
Date: Mon, 27 Nov 2017 17:16:53 -0500 [thread overview]
Message-ID: <1850273.jPBnK7MvUs@x2> (raw)
In-Reply-To: <1511395257-6321-3-git-send-email-rgb@redhat.com>
On Wednesday, November 22, 2017 7:00:57 PM EST Richard Guy Briggs wrote:
> The kernel always returns negative values on error, so zero and anything
> positive is valid success. Lost_reset returned a positive value at the
> time of reset, including zero that got interpreted as success and
> replaced with the packet sequence number "2".
>
> Rename audit_send() to __audit_send() and pass the sequence number back
> via a parameter rather than return value.
>
> Have a new stub audit_send() call __audit_send() and mimic the previous
> behaviour of audit_send()
Applied,
Thanks,
-Steve
prev parent reply other threads:[~2017-11-27 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 0:00 [PATCH 0/2] lost_reset: alt fix restoring designed behaviour Richard Guy Briggs
2017-11-23 0:00 ` [PATCH 1/2] Revert "In auditctl, when resetting lost request status output afterwards" Richard Guy Briggs
2017-11-27 22:16 ` Steve Grubb
2017-11-27 22:41 ` Richard Guy Briggs
2017-11-27 23:06 ` Steve Grubb
2017-11-23 0:00 ` [PATCH 2/2] lost_reset: return value rather than sequence number when zero Richard Guy Briggs
2017-11-27 22:16 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1850273.jPBnK7MvUs@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.