All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] pci: fix level of scan debug log on BSD
Date: Thu, 03 Aug 2017 17:36:41 +0200	[thread overview]
Message-ID: <1852586.cdvAFzMDef@xps> (raw)
In-Reply-To: <20170803101622.GA42296@bricha3-MOBL3.ger.corp.intel.com>

03/08/2017 12:16, Bruce Richardson:
> On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
> > Printing the number of scanned devices should be a debug log,
> > not an error.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
[...]
> > -	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
> > +	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
> >  	return 0;
> >  
> would have gone for INFO level myself, but DEBUG works too - it's
> definitely not an error.
> The commit title also reads a bit strange to me. How about e.g.:
> "pci: log fix level of PCI scan summary message on BSD"
> 
> Otherwise:
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

      reply	other threads:[~2017-08-03 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 17:10 [PATCH] pci: fix level of scan debug log on BSD Thomas Monjalon
2017-08-03 10:16 ` Bruce Richardson
2017-08-03 15:36   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1852586.cdvAFzMDef@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.