All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Bryan Evenson <bevenson@melinkcorp.com>
Cc: poky@yoctoproject.org
Subject: Re: Errors attempting to build AT91SAM9x5 BSP
Date: Thu, 15 Nov 2012 11:03:01 +0000	[thread overview]
Message-ID: <18536739.oUeeJqhr6W@helios> (raw)
In-Reply-To: <91586D499ADFD74FBCFB8425266A5DE4012C7CF328B4@pluto.melinkcorp.local>

On Tuesday 13 November 2012 14:17:06 Bryan Evenson wrote:
> Thanks for the information.  From my reading of the BSP manual I'd thought I
> was supposed to increment the LCONF_VERSION each time I made a change to
> the bblayers.conf file; I appreciate the clarification.

Could you suggest a change to the BSP manual that would help avoid this 
confusion?
 
> I searched for the error message I was getting, and I think it was
> originating in this section of sanity.bbclass:
> 
>     # Check bblayers.conf is valid
>     current_lconf = sanity_data.getVar('LCONF_VERSION', True)
>     lconf_version = sanity_data.getVar('LAYER_CONF_VERSION', True)
>     if current_lconf != lconf_version:
>         try:
>             bb.build.exec_func("check_bblayers_conf", sanity_data)
>             if sanity_data.getVar("SANITY_USE_EVENTS", True) == "1":
>                 bb.event.fire(bb.event.SanityCheckFailed("Your
> conf/bblayers.conf has been automatically updated. Please close and
> re-run."), sanity_data) return
>             else:
>                 bb.note("Your conf/bblayers.conf has been automatically
> updated. Please re-run %s." % os.path.basename(sys.argv[0])) sys.exit(0)
>         except Exception:
>             messages = messages + "Your version of bblayers.conf was
> generated from an older version of bblayers.conf.sample and there have been
> updates made to this file. Please compare the two files and merge any
> changes before continuing.\nMatching the version numbers will remove this
> message.\n\"meld conf/bblayers.conf
> ${COREBASE}/meta*/conf/bblayers.conf.sample\" is a good way to visualise
> the changes.\n"

Right, I guess (without having tested it recently) what I expected to happen 
was the check_bblayers_conf function would have raised an exception if it 
couldn't do anything with the file; currently it doesn't.

> Would it be helpful if the current_lconf != lconf_version check changed to
> have different messages when current_lconf > lconf_version and when
> current_lcong < lconf_version?

I think that would be a good idea, yes.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2012-11-15 11:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 18:27 Errors attempting to build AT91SAM9x5 BSP Bryan Evenson
2012-11-13 16:26 ` Bryan Evenson
2012-11-13 17:10   ` Paul Eggleton
2012-11-13 17:46     ` Bryan Evenson
2012-11-13 17:52       ` Paul Eggleton
2012-11-13 19:17         ` Bryan Evenson
2012-11-15 11:03           ` Paul Eggleton [this message]
2012-11-19 16:35           ` Bryan Evenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18536739.oUeeJqhr6W@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=bevenson@melinkcorp.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.