All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>, linux-pm@vger.kernel.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, rjw@rjwysocki.net,
	khilman@kernel.org, ulf.hansson@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	wxt@rock-chips.com, xxx@rock-chips.com, xf@rock-chips.com,
	huangtao@rock-chips.com, Finley Xiao <finley.xiao@rock-chips.com>
Subject: Re: [PATCH v2 04/13] soc: rockchip: power-domain: Fix wrong value when power up pd
Date: Mon, 14 May 2018 11:45:05 +0200	[thread overview]
Message-ID: <1861053.XlXe5vHN1s@phil> (raw)
In-Reply-To: <1526268578-9361-1-git-send-email-zhangqing@rock-chips.com>

Hi Elaine,

Am Montag, 14. Mai 2018, 05:29:38 CEST schrieb Elaine Zhang:
> From: Finley Xiao <finley.xiao@rock-chips.com>
> 
> Solve the pd could only ever turn off but never turn them on again,
> If the pd registers have the writemask bits.
> 
> Fix up the code error for commit:
> 	commit 79bb17ce8edb3141339b5882e372d0ec7346217c
> 	Author: Elaine Zhang <zhangqing@rock-chips.com>
> 	Date:   Fri Dec 23 11:47:52 2016 +0800
> 
> 	soc: rockchip: power-domain: Support domain control in hiword-registers
> 
> 	New Rockchips SoCs may have their power-domain control in registers
> 	using a writemask-based access scheme (upper 16bit being the write
> 	mask). So add a DOMAIN_M type and handle this case accordingly.
> 	Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> 	Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>

As Gregs automated mail noted, the stable-notice needed some changes.

I've done these changes and applied the result for 4.18.

When you look at [0] you'll see  the two lines "Fixes:..." and "Cc:..."
in the commit message. Greg then has automated scripts running that
extract so marked patches from Linus' tree and queue them for possible
stable-inclusion.

[The other patches need to wait a bit to give Rob a chance to Ack them]

Heiko


[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=ed726894761c056b3513ce15915af74ce5d7d57b

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/13] soc: rockchip: power-domain: Fix wrong value when power up pd
Date: Mon, 14 May 2018 11:45:05 +0200	[thread overview]
Message-ID: <1861053.XlXe5vHN1s@phil> (raw)
In-Reply-To: <1526268578-9361-1-git-send-email-zhangqing@rock-chips.com>

Hi Elaine,

Am Montag, 14. Mai 2018, 05:29:38 CEST schrieb Elaine Zhang:
> From: Finley Xiao <finley.xiao@rock-chips.com>
> 
> Solve the pd could only ever turn off but never turn them on again,
> If the pd registers have the writemask bits.
> 
> Fix up the code error for commit:
> 	commit 79bb17ce8edb3141339b5882e372d0ec7346217c
> 	Author: Elaine Zhang <zhangqing@rock-chips.com>
> 	Date:   Fri Dec 23 11:47:52 2016 +0800
> 
> 	soc: rockchip: power-domain: Support domain control in hiword-registers
> 
> 	New Rockchips SoCs may have their power-domain control in registers
> 	using a writemask-based access scheme (upper 16bit being the write
> 	mask). So add a DOMAIN_M type and handle this case accordingly.
> 	Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> 	Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>

As Gregs automated mail noted, the stable-notice needed some changes.

I've done these changes and applied the result for 4.18.

When you look at [0] you'll see  the two lines "Fixes:..." and "Cc:..."
in the commit message. Greg then has automated scripts running that
extract so marked patches from Linus' tree and queue them for possible
stable-inclusion.

[The other patches need to wait a bit to give Rob a chance to Ack them]

Heiko


[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=ed726894761c056b3513ce15915af74ce5d7d57b

  parent reply	other threads:[~2018-05-14  9:45 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  3:27 [PATCH v2 00/13] add power domain support for Rockchip Socs Elaine Zhang
2018-05-14  3:27 ` Elaine Zhang
2018-05-14  3:28 ` [PATCH v2 01/13] dt-bindings: power: add RK3036 SoCs header for power-domain Elaine Zhang
2018-05-14  3:28   ` Elaine Zhang
2018-05-22 17:34   ` Rob Herring
2018-05-22 17:34     ` Rob Herring
2018-05-14  3:28 ` [PATCH v2 02/13] dt-bindings: add binding for rk3036 power domains Elaine Zhang
2018-05-14  3:28   ` Elaine Zhang
2018-05-22 17:34   ` Rob Herring
2018-05-22 17:34     ` Rob Herring
2018-05-14  3:29 ` [PATCH v2 03/13] Soc: rockchip: power-domain: add power domain support for rk3036 Elaine Zhang
2018-05-14  3:29   ` Elaine Zhang
2018-05-14  3:29 ` [PATCH v2 04/13] soc: rockchip: power-domain: Fix wrong value when power up pd Elaine Zhang
2018-05-14  3:29   ` Elaine Zhang
2018-05-14  6:16   ` Greg KH
2018-05-14  6:16     ` Greg KH
2018-05-14  9:45   ` Heiko Stuebner [this message]
2018-05-14  9:45     ` Heiko Stuebner
2018-05-14  3:30 ` [PATCH v2 05/13] dt-bindings: power: add RK3128 SoCs header for power-domain Elaine Zhang
2018-05-14  3:30   ` Elaine Zhang
2018-05-22 17:35   ` Rob Herring
2018-05-22 17:35     ` Rob Herring
2018-05-14  3:30 ` [PATCH v2 06/13] dt-bindings: add binding for rk3128 power domains Elaine Zhang
2018-05-14  3:30   ` Elaine Zhang
2018-05-22 17:36   ` Rob Herring
2018-05-22 17:36     ` Rob Herring
2018-05-14  3:30 ` [PATCH v2 07/13] soc: rockchip: power-domain: add power domain support for rk3128 Elaine Zhang
2018-05-14  3:30   ` Elaine Zhang
2018-05-14  3:31 ` [PATCH v2 08/13] dt-bindings: power: add RK3228 SoCs header for power-domain Elaine Zhang
2018-05-14  3:31   ` Elaine Zhang
2018-05-22 17:37   ` Rob Herring
2018-05-22 17:37     ` Rob Herring
2018-05-14  3:31 ` [PATCH v2 09/13] dt-bindings: add binding for rk3228 power domains Elaine Zhang
2018-05-14  3:31   ` Elaine Zhang
2018-05-22 17:38   ` Rob Herring
2018-05-22 17:38     ` Rob Herring
2018-05-14  3:31 ` [PATCH v2 10/13] soc: rockchip: power-domain: add power domain support for rk3228 Elaine Zhang
2018-05-14  3:31   ` Elaine Zhang
2018-05-14  3:32 ` [PATCH v2 11/13] dt-bindings: power: add PX30 SoCs header for power-domain Elaine Zhang
2018-05-14  3:32   ` Elaine Zhang
2018-05-22 17:39   ` Rob Herring
2018-05-22 17:39     ` Rob Herring
2018-05-14  3:32 ` [PATCH v2 12/13] dt-bindings: add binding for px30 power domains Elaine Zhang
2018-05-14  3:32   ` Elaine Zhang
2018-05-14  3:32 ` [PATCH v2 13/13] soc: rockchip: power-domain: add power domain support for px30 Elaine Zhang
2018-05-14  3:32   ` Elaine Zhang
2018-05-14  9:51 ` [PATCH v2 00/13] add power domain support for Rockchip Socs Ulf Hansson
2018-05-14  9:51   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1861053.XlXe5vHN1s@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=finley.xiao@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wxt@rock-chips.com \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.