From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-samsung-soc@vger.kernel.org, vinod.koul@intel.com,
sbkim73@samsung.com, andi.shyti@samsung.com,
javier@osg.samsung.com, broonie@kernel.org, kgene@kernel.org,
dmaengine@vger.kernel.org, ckeepax@opensource.wolfsonmicro.com,
ym0914@gmail.com
Subject: Re: [PATCH RFC 4/7] ASoC: samsung: i2s: Do not use platform_data for DMA parameters
Date: Mon, 07 Nov 2016 22:14:34 +0100 [thread overview]
Message-ID: <1863253.DX7iDsal5P@wuerfel> (raw)
In-Reply-To: <c4388f30-702b-895b-5280-6fabf8e7bfe1@samsung.com>
On Monday, November 7, 2016 5:02:54 PM CET Sylwester Nawrocki wrote:
> On 11/05/2016 12:29 AM, Arnd Bergmann wrote:
> > On Friday 04 November 2016, Sylwester Nawrocki wrote:
> >> > - ret = samsung_asoc_dma_platform_register(&pdev->dev, pri_dai->filter,
> >> > + ret = samsung_asoc_dma_platform_register(&pdev->dev, NULL,
> >> > NULL, NULL);
> >
> > If we remove the filter argument from every caller here, maybe we should also
> > change the prototype to not expect those three NULL arguments any more.
>
> There is one occurrence where the third argument needs to be not NULL.
> I'm planning to modify sound/sound/samsung/i2s.c so there is no need
> to create another platform device just for the overlay DAI, afterwards
> the above function could be simplified.
Ok, sounds good.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 4/7] ASoC: samsung: i2s: Do not use platform_data for DMA parameters
Date: Mon, 07 Nov 2016 22:14:34 +0100 [thread overview]
Message-ID: <1863253.DX7iDsal5P@wuerfel> (raw)
In-Reply-To: <c4388f30-702b-895b-5280-6fabf8e7bfe1@samsung.com>
On Monday, November 7, 2016 5:02:54 PM CET Sylwester Nawrocki wrote:
> On 11/05/2016 12:29 AM, Arnd Bergmann wrote:
> > On Friday 04 November 2016, Sylwester Nawrocki wrote:
> >> > - ret = samsung_asoc_dma_platform_register(&pdev->dev, pri_dai->filter,
> >> > + ret = samsung_asoc_dma_platform_register(&pdev->dev, NULL,
> >> > NULL, NULL);
> >
> > If we remove the filter argument from every caller here, maybe we should also
> > change the prototype to not expect those three NULL arguments any more.
>
> There is one occurrence where the third argument needs to be not NULL.
> I'm planning to modify sound/sound/samsung/i2s.c so there is no need
> to create another platform device just for the overlay DAI, afterwards
> the above function could be simplified.
Ok, sounds good.
Arnd
next prev parent reply other threads:[~2016-11-07 21:15 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 16:14 [PATCH RFC 0/7] DMA: S3C64XX: Conversion to the new channel request API Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-08 15:39 ` Charles Keepax
2016-11-08 15:39 ` Charles Keepax
2016-11-08 16:02 ` Sylwester Nawrocki
2016-11-08 16:02 ` Sylwester Nawrocki
2016-11-04 16:14 ` [PATCH RFC 1/7] dma: pl08x: Add support for the DMA slave map Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-04 23:26 ` Arnd Bergmann
2016-11-04 23:26 ` Arnd Bergmann
2016-11-07 15:41 ` Sylwester Nawrocki
2016-11-07 15:41 ` Sylwester Nawrocki
2016-11-07 19:55 ` Arnd Bergmann
2016-11-07 19:55 ` Arnd Bergmann
2016-11-14 11:51 ` Sylwester Nawrocki
2016-11-14 11:51 ` Sylwester Nawrocki
2016-11-04 16:14 ` [PATCH RFC 2/7] ARM: S3C64XX: Add DMA slave maps for PL080 devices Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-08 14:44 ` Charles Keepax
2016-11-08 14:44 ` Charles Keepax
2016-11-08 14:55 ` Charles Keepax
2016-11-08 14:55 ` Charles Keepax
2016-11-08 15:53 ` Sylwester Nawrocki
2016-11-08 15:53 ` Sylwester Nawrocki
2016-11-10 11:03 ` Charles Keepax
2016-11-10 11:03 ` Charles Keepax
2016-11-10 15:10 ` Sylwester Nawrocki
2016-11-10 15:10 ` Sylwester Nawrocki
2016-11-10 15:18 ` Charles Keepax
2016-11-10 15:18 ` Charles Keepax
2016-11-04 16:14 ` [PATCH RFC 3/7] spi: s3c64xx: Do not use platform_data for DMA parameters Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-04 17:12 ` Mark Brown
2016-11-04 17:12 ` Mark Brown
2016-11-07 2:51 ` Andi Shyti
2016-11-07 2:51 ` Andi Shyti
2016-11-04 16:14 ` [PATCH RFC 4/7] ASoC: samsung: i2s: " Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-04 17:13 ` Mark Brown
2016-11-04 17:13 ` Mark Brown
2016-11-04 23:29 ` Arnd Bergmann
2016-11-04 23:29 ` Arnd Bergmann
2016-11-07 16:02 ` Sylwester Nawrocki
2016-11-07 16:02 ` Sylwester Nawrocki
2016-11-07 21:14 ` Arnd Bergmann [this message]
2016-11-07 21:14 ` Arnd Bergmann
2016-11-04 16:14 ` [PATCH RFC 5/7] ASoC: samsung: pcm: " Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-04 17:13 ` Mark Brown
2016-11-04 17:13 ` Mark Brown
2016-11-04 16:14 ` [PATCH RFC 6/7] ARM: S3C64XX: Drop unused DMA fields from struct s3c64xx_spi_csinfo Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-04 16:14 ` [PATCH RFC 7/7] ARM: S3C64XX: Drop initialization of unused struct s3c_audio_pdata fields Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1863253.DX7iDsal5P@wuerfel \
--to=arnd@arndb.de \
--cc=andi.shyti@samsung.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dmaengine@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=vinod.koul@intel.com \
--cc=ym0914@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.