Re: [PATCH 1/2] arm64: dts: rockchip: use Type-C port as USB HOST port for Radxa ROCK 5B

From: "Heiko Stübner" <heiko@sntech.de>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, conor+dt@kernel.org, inindev@gmail.com,
	devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
	linux-rockchip@lists.infradead.org, alchark@gmail.com,
	FUKAUMI Naoki <naoki@radxa.com>,
	krzk+dt@kernel.org, dsimic@manjaro.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: use Type-C port as USB HOST port for Radxa ROCK 5B
Date: Tue, 03 Dec 2024 17:18:39 +0100	[thread overview]
Message-ID: <18640241.sWSEgdgrri@diego> (raw)
In-Reply-To: <20241130014043.12942-1-naoki@radxa.com>

Am Samstag, 30. November 2024, 02:40:42 CET schrieb FUKAUMI Naoki:
> Type-C port is dual-role USB 3.0 port. add usb_host0_xhci and phy
> nodes to use it as HOST port.

This needs a bit more explanation on _why_ you're statically
setting this to host-mode.

Heiko

> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 0ec4992b43cd..c5776e3b4aab 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -840,6 +840,14 @@ &tsadc {
>  	status = "okay";
>  };
>  
> +&u2phy0 {
> +	status = "okay";
> +};
> +
> +&u2phy0_otg {
> +	status = "okay";
> +};
> +
>  &u2phy1 {
>  	status = "okay";
>  };
> @@ -883,6 +891,11 @@ &usb_host0_ehci {
>  	status = "okay";
>  };
>  
> +&usb_host0_xhci {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
>  &usb_host1_ehci {
>  	status = "okay";
>  };
> @@ -900,6 +913,10 @@ &usb_host2_xhci {
>  	status = "okay";
>  };
>  
> +&usbdp_phy0 {
> +	status = "okay";
> +};
> +
>  &usbdp_phy1 {
>  	status = "okay";
>  };
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip