From: Markus Elfring <Markus.Elfring@web.de>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, cocci@inria.fr,
"Heiko Stübner" <heiko@sntech.de>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [cocci] [PATCH] pmdomain: rockchip: Simplify dropping OF node reference
Date: Fri, 13 Sep 2024 15:16:09 +0200 [thread overview]
Message-ID: <186de981-7a3c-4fdb-8911-8dfee597c759@web.de> (raw)
In-Reply-To: <20240825183116.102953-1-krzysztof.kozlowski@linaro.org>
> Drop OF node reference immediately after using it in
> syscon_node_to_regmap(), which is both simpler and typical/expected
> code pattern.
Dear Krzysztof,
I noticed also this contribution.
I found it easy to convert it also into the following small script variant
for the semantic patch language (Coccinelle software).
@adjustment@
expression e, x;
@@
+of_node_put(e);
if (...)
{
<+... when != e = x
- of_node_put(e);
...+>
}
-of_node_put(e);
58 patches were accordingly generated for source files of the software “Linux next-20240913”.
How would we like to tackle remaining update candidates according to similar transformation patterns?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, cocci@inria.fr,
"Heiko Stübner" <heiko@sntech.de>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pmdomain: rockchip: Simplify dropping OF node reference
Date: Fri, 13 Sep 2024 15:16:09 +0200 [thread overview]
Message-ID: <186de981-7a3c-4fdb-8911-8dfee597c759@web.de> (raw)
In-Reply-To: <20240825183116.102953-1-krzysztof.kozlowski@linaro.org>
> Drop OF node reference immediately after using it in
> syscon_node_to_regmap(), which is both simpler and typical/expected
> code pattern.
Dear Krzysztof,
I noticed also this contribution.
I found it easy to convert it also into the following small script variant
for the semantic patch language (Coccinelle software).
@adjustment@
expression e, x;
@@
+of_node_put(e);
if (...)
{
<+... when != e = x
- of_node_put(e);
...+>
}
-of_node_put(e);
58 patches were accordingly generated for source files of the software “Linux next-20240913”.
How would we like to tackle remaining update candidates according to similar transformation patterns?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, cocci@inria.fr,
"Heiko Stübner" <heiko@sntech.de>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pmdomain: rockchip: Simplify dropping OF node reference
Date: Fri, 13 Sep 2024 15:16:09 +0200 [thread overview]
Message-ID: <186de981-7a3c-4fdb-8911-8dfee597c759@web.de> (raw)
In-Reply-To: <20240825183116.102953-1-krzysztof.kozlowski@linaro.org>
> Drop OF node reference immediately after using it in
> syscon_node_to_regmap(), which is both simpler and typical/expected
> code pattern.
Dear Krzysztof,
I noticed also this contribution.
I found it easy to convert it also into the following small script variant
for the semantic patch language (Coccinelle software).
@adjustment@
expression e, x;
@@
+of_node_put(e);
if (...)
{
<+... when != e = x
- of_node_put(e);
...+>
}
-of_node_put(e);
58 patches were accordingly generated for source files of the software “Linux next-20240913”.
How would we like to tackle remaining update candidates according to similar transformation patterns?
Regards,
Markus
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-13 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 18:31 [PATCH] pmdomain: rockchip: Simplify dropping OF node reference Krzysztof Kozlowski
2024-08-25 18:31 ` Krzysztof Kozlowski
2024-08-25 18:52 ` Heiko Stübner
2024-08-25 18:52 ` Heiko Stübner
2024-09-13 12:01 ` Ulf Hansson
2024-09-13 12:01 ` Ulf Hansson
2024-09-13 13:16 ` Markus Elfring [this message]
2024-09-13 13:16 ` Markus Elfring
2024-09-13 13:16 ` Markus Elfring
2024-09-14 14:40 ` [cocci] Generalising a transformation with SmPL? Markus Elfring
2024-09-14 14:40 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=186de981-7a3c-4fdb-8911-8dfee597c759@web.de \
--to=markus.elfring@web.de \
--cc=cocci@inria.fr \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.